Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 16007004: Make selection solid and blue in Files.app. (Closed)

Created:
7 years, 6 months ago by mtomasz
Modified:
7 years, 6 months ago
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Make selection solid and blue in Files.app. Previously, the selection was getting gray when using the 'select-all' checkbox, because it was taking the focus. This patch fixes this issue by preventing from stealing the focus when clicking anywhere on the header. Moreover, the separating lines in the file list have been removed to match the recent specs. TEST=Tested manually. Go to Files.app, select all using the checkbox. BUG=239284 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202822

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/browser/resources/file_manager/js/file_table.js View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
mtomasz
@yoshiki: PTAL. Thanks.
7 years, 6 months ago (2013-05-28 06:28:45 UTC) #1
yoshiki
7 years, 6 months ago (2013-05-28 07:39:23 UTC) #2
yoshiki
lgtm
7 years, 6 months ago (2013-05-28 07:39:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/16007004/1
7 years, 6 months ago (2013-05-28 07:39:42 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=118927
7 years, 6 months ago (2013-05-28 09:56:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/16007004/1
7 years, 6 months ago (2013-05-29 02:52:47 UTC) #6
commit-bot: I haz the power
Failed to apply patch for chrome/browser/resources/file_manager/css/file_manager.css: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 6 months ago (2013-05-29 02:52:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/16007004/18001
7 years, 6 months ago (2013-05-29 03:31:35 UTC) #8
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 6 months ago (2013-05-29 04:02:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/16007004/18001
7 years, 6 months ago (2013-05-29 04:44:00 UTC) #10
commit-bot: I haz the power
7 years, 6 months ago (2013-05-29 08:28:14 UTC) #11
Message was sent while issue was closed.
Change committed as 202822

Powered by Google App Engine
This is Rietveld 408576698