chrome.tabs.query: Allow extensions with host permission to see tabs of that host.

chrome.tabs.query: Allow extensions with host permission to see tabs of that host.

r368222 made chrome.tabs.query restrict extensions without effective tabs
  permission from looking at a tab's URL. This CL relaxes the restriction
  letting tabs with specific host(s) permission to look at tabs at that
  host(s).

BUG=572545
Test=See bug for details:
https://code.google.com/p/chromium/issues/detail?id=572545#c9

Committed: https://crrev.com/f49ce9359208243bf74d08ae9bc9e41dd24b572d
Cr-Commit-Position: refs/heads/master@{#370760}

[lazyboy, 2016-01-20 00:38:12]

Description was changed from

==========
chrome.tabs.query: Allow extensions with host permission to see tabs of that
host.

r368222 made chrome.tabs.query restricts extensions without effective tabs
  permission from looking at a tab's URL. This CL relaxes the restriction
  letting tabs with a specific host(s) permission to look at tabs at that
  host(s).

BUG=572545
Test=See bug for details:
https://code.google.com/p/chromium/issues/detail?id=572545#c9
==========

to

==========
chrome.tabs.query: Allow extensions with host permission to see tabs of that
host.

r368222 made chrome.tabs.query restrict extensions without effective tabs
  permission from looking at a tab's URL. This CL relaxes the restriction
  letting tabs with specific host(s) permission to look at tabs at that
  host(s).

BUG=572545
Test=See bug for details:
https://code.google.com/p/chromium/issues/detail?id=572545#c9
==========

[lazyboy, 2016-01-20 00:38:23]

lazyboy@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[Devlin, 2016-01-20 18:15:40]

lgtm

https://chromiumcodereview.appspot.com/1600553006/diff/20001/chrome/browser/e...
File chrome/browser/extensions/api/tabs/tabs_api.cc (right):

https://chromiumcodereview.appspot.com/1600553006/diff/20001/chrome/browser/e...
chrome/browser/extensions/api/tabs/tabs_api.cc:996: if
(extension_->permissions_data()->HasAPIPermissionForTab(
nitty nit: I find this slightly more readable as:
if (!<has permission>)
  continue;
if (!title.empty() && !<matches>)
  continue;
if (!url_patterns.empty() && !<matches>)
  continue;

i.e., change the condition here and remove the "else" clause on line 1011.  It
just makes it flow better so that we don't have to trace where the else matches,
and has better symmetry with the rest of our "if (!foo) continue;" code.

https://chromiumcodereview.appspot.com/1600553006/diff/20001/chrome/browser/e...
File chrome/browser/extensions/api/tabs/tabs_api_unittest.cc (right):

https://chromiumcodereview.appspot.com/1600553006/diff/20001/chrome/browser/e...
chrome/browser/extensions/api/tabs/tabs_api_unittest.cc:154: // An extension
with "host" permission however will only see the third tab.
This "however" seems out of place, since it's the first part of the test.

https://chromiumcodereview.appspot.com/1600553006/diff/20001/chrome/browser/e...
chrome/browser/extensions/api/tabs/tabs_api_unittest.cc:174: int third_tab_id;
nitty nit: for completeness, please initialize pod values

https://chromiumcodereview.appspot.com/1600553006/diff/20001/chrome/browser/e...
chrome/browser/extensions/api/tabs/tabs_api_unittest.cc:179: // Try the same w/o
title, first and third tab will match.
nitty nit: shy away from abbreviations like w/o

[lazyboy, 2016-01-20 19:12:29]

https://chromiumcodereview.appspot.com/1600553006/diff/20001/chrome/browser/e...
File chrome/browser/extensions/api/tabs/tabs_api.cc (right):

https://chromiumcodereview.appspot.com/1600553006/diff/20001/chrome/browser/e...
chrome/browser/extensions/api/tabs/tabs_api.cc:996: if
(extension_->permissions_data()->HasAPIPermissionForTab(
On 2016/01/20 18:15:40, Devlin wrote:
> nitty nit: I find this slightly more readable as:
> if (!<has permission>)
>   continue;
> if (!title.empty() && !<matches>)
>   continue;
> if (!url_patterns.empty() && !<matches>)
>   continue;
> 
> i.e., change the condition here and remove the "else" clause on line 1011.  It
> just makes it flow better so that we don't have to trace where the else
matches,
> and has better symmetry with the rest of our "if (!foo) continue;" code.

Done.

https://chromiumcodereview.appspot.com/1600553006/diff/20001/chrome/browser/e...
File chrome/browser/extensions/api/tabs/tabs_api_unittest.cc (right):

https://chromiumcodereview.appspot.com/1600553006/diff/20001/chrome/browser/e...
chrome/browser/extensions/api/tabs/tabs_api_unittest.cc:154: // An extension
with "host" permission however will only see the third tab.
On 2016/01/20 18:15:40, Devlin wrote:
> This "however" seems out of place, since it's the first part of the test.

Done.

https://chromiumcodereview.appspot.com/1600553006/diff/20001/chrome/browser/e...
chrome/browser/extensions/api/tabs/tabs_api_unittest.cc:174: int third_tab_id;
On 2016/01/20 18:15:40, Devlin wrote:
> nitty nit: for completeness, please initialize pod values

Done.

https://chromiumcodereview.appspot.com/1600553006/diff/20001/chrome/browser/e...
chrome/browser/extensions/api/tabs/tabs_api_unittest.cc:179: // Try the same w/o
title, first and third tab will match.
On 2016/01/20 18:15:40, Devlin wrote:
> nitty nit: shy away from abbreviations like w/o

Done.

[lazyboy, 2016-01-21 19:27:26]

The CQ bit was checked by lazyboy@chromium.org

[lazyboy, 2016-01-21 19:27:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1600553006/#ps80001
(title: "fix mistake while addressing comments")

[commit-bot: I haz the power, 2016-01-21 19:30:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1600553006/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1600553006/80001

[commit-bot: I haz the power, 2016-01-21 19:54:19]

Description was changed from

==========
chrome.tabs.query: Allow extensions with host permission to see tabs of that
host.

r368222 made chrome.tabs.query restrict extensions without effective tabs
  permission from looking at a tab's URL. This CL relaxes the restriction
  letting tabs with specific host(s) permission to look at tabs at that
  host(s).

BUG=572545
Test=See bug for details:
https://code.google.com/p/chromium/issues/detail?id=572545#c9
==========

to

==========
chrome.tabs.query: Allow extensions with host permission to see tabs of that
host.

r368222 made chrome.tabs.query restrict extensions without effective tabs
  permission from looking at a tab's URL. This CL relaxes the restriction
  letting tabs with specific host(s) permission to look at tabs at that
  host(s).

BUG=572545
Test=See bug for details:
https://code.google.com/p/chromium/issues/detail?id=572545#c9
==========

[commit-bot: I haz the power, 2016-01-21 19:54:19]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-01-21 19:55:23]

Description was changed from

==========
chrome.tabs.query: Allow extensions with host permission to see tabs of that
host.

r368222 made chrome.tabs.query restrict extensions without effective tabs
  permission from looking at a tab's URL. This CL relaxes the restriction
  letting tabs with specific host(s) permission to look at tabs at that
  host(s).

BUG=572545
Test=See bug for details:
https://code.google.com/p/chromium/issues/detail?id=572545#c9
==========

to

==========
chrome.tabs.query: Allow extensions with host permission to see tabs of that
host.

r368222 made chrome.tabs.query restrict extensions without effective tabs
  permission from looking at a tab's URL. This CL relaxes the restriction
  letting tabs with specific host(s) permission to look at tabs at that
  host(s).

BUG=572545
Test=See bug for details:
https://code.google.com/p/chromium/issues/detail?id=572545#c9

Committed: https://crrev.com/f49ce9359208243bf74d08ae9bc9e41dd24b572d
Cr-Commit-Position: refs/heads/master@{#370760}
==========

[commit-bot: I haz the power, 2016-01-21 19:55:24]

Patchset 5 (id:??) landed as
https://crrev.com/f49ce9359208243bf74d08ae9bc9e41dd24b572d
Cr-Commit-Position: refs/heads/master@{#370760}