linux_aura: Implement the fallback path in IsX11WindowFullScreen.

linux_aura: Implement the fallback path in IsX11WindowFullScreen.

This has recently started spewing. Implement the fallback path.

BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203828

[Daniel Erat, 2013-06-01 03:05:59]

https://codereview.chromium.org/16002008/diff/1/ui/base/x/x11_util.cc
File ui/base/x/x11_util.cc (right):

https://codereview.chromium.org/16002008/diff/1/ui/base/x/x11_util.cc#newcode...
ui/base/x/x11_util.cc:1319: std::find(atom_properties.begin(),
atom_properties.end(), atom)
i don't think that this is correct. see
http://standards.freedesktop.org/wm-spec/wm-spec-latest.html#idp3331912. i think
that you should check _NET_SUPPORTED to see if the window manager supports
_NET_WM_STATE_FULLSCREEN. if it does, return true if _NET_WM_STATE contains the
fullscreen property and false if it doesn't. this should prevent the later code
from being executed as long as a decent window manager is being used.

https://codereview.chromium.org/16002008/diff/1/ui/base/x/x11_util.cc#newcode...
ui/base/x/x11_util.cc:1340: ::Display* display = ui::GetXDisplay();
this will probably break in the multi-monitor case -- presumably you'd need to
use xrandr or xinerama to get the bounds of the monitor where the window is
being displayed. at least, i'm assuming that most window managers won't
fullscreen windows across multiple monitors. if you implement the above
suggestion, this is probably enough of a corner case that i wouldn't worry about
it (e.g. i don't think that ion3 sets the fullscreen property, but it also
doesn't do per-monitor fullscreening, so whatever).

[Elliot Glaysher, 2013-06-03 18:19:34]

ptal

[Daniel Erat, 2013-06-03 18:34:39]

LGTM. Thanks!

https://codereview.chromium.org/16002008/diff/5001/ui/base/x/x11_util.cc
File ui/base/x/x11_util.cc (right):

https://codereview.chromium.org/16002008/diff/5001/ui/base/x/x11_util.cc#newc...
ui/base/x/x11_util.cc:1323: 
nit: delete extra blank line

[commit-bot: I haz the power, 2013-06-03 19:12:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/16002008/9001

[commit-bot: I haz the power, 2013-06-04 03:42:21]

Change committed as 203828