Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 15995031: cc: Don't clear transparent piles to an opaque color (Closed)

Created:
7 years, 6 months ago by enne (OOO)
Modified:
7 years, 6 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org, Xianzhu
Visibility:
Public.

Description

cc: Don't clear transparent piles to an opaque color The pile background color is what the pile gets cleared to to fill partially rastered pixels. If the layer is not opaque, clearing to an opaque color leaves opaque artifacts. Fix this by adding a function to return a safe color to clear the pile to or to draw solid color quads from by requiring that this color be opaque iff the contents of the layer are opaque. R=danakj@chromium.org BUG=245624 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204048

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -18 lines) Patch
M cc/layers/layer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/layers/layer.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M cc/layers/layer_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/layers/layer_impl.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M cc/layers/layer_impl_unittest.cc View 1 chunk +30 lines, -0 lines 0 comments Download
M cc/layers/layer_unittest.cc View 1 chunk +31 lines, -0 lines 0 comments Download
M cc/layers/picture_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/picture_layer_impl.cc View 1 chunk +1 line, -17 lines 0 comments Download
M cc/trees/layer_tree_host.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
enne (OOO)
7 years, 6 months ago (2013-06-03 22:55:59 UTC) #1
danakj
LGTM We need a LayerCommon class or something.
7 years, 6 months ago (2013-06-04 14:34:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/15995031/1
7 years, 6 months ago (2013-06-04 15:33:21 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-04 21:14:51 UTC) #4
Message was sent while issue was closed.
Change committed as 204048

Powered by Google App Engine
This is Rietveld 408576698