Web MIDI: implement MIDIAccessPromise

Source/modules/webmidi/MIDIAccessPromise.h

Index: Source/modules/webmidi/MIDIAccessPromise.h
diff --git a/Source/modules/webmidi/MIDIAccessPromise.h b/Source/modules/webmidi/MIDIAccessPromise.h
new file mode 100644
index 0000000000000000000000000000000000000000..ea72155f8cef084057dd2b3e648c935770545c0e
--- /dev/null
+++ b/Source/modules/webmidi/MIDIAccessPromise.h
@@ -0,0 +1,85 @@
+/*
+ * Copyright (C) 2013 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ *     * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ *     * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ *     * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef MIDIAccessPromise_h
+#define MIDIAccessPromise_h
+
+#include "bindings/v8/ScriptWrappable.h"
+#include "core/dom/ActiveDOMObject.h"
+#include "modules/webmidi/MIDIOptions.h"
+#include "wtf/OwnPtr.h"
+#include "wtf/PassRefPtr.h"
+#include "wtf/RefCounted.h"
+
+namespace WebCore {
+
+class DOMError;
+class MIDIAccess;
+class MIDIErrorCallback;
+class MIDISuccessCallback;
+class ScriptExecutionContext;
+
+struct MIDIOptions;
+
+class MIDIAccessPromise : public RefCounted<MIDIAccessPromise>, public ScriptWrappable, public ActiveDOMObject {
+public:
+    static PassRefPtr<MIDIAccessPromise> create(ScriptExecutionContext*, const Dictionary&);
+    virtual ~MIDIAccessPromise();
+
+    void then(PassRefPtr<MIDISuccessCallback>, PassRefPtr<MIDIErrorCallback>);
+
+    // ActiveDOMObject
+    virtual bool canSuspend() const OVERRIDE { return true; }

[Chris Rogers, 2013/06/07 04:27:25]

For ActiveDOMObject, I think you also need to implement     virtual bool
hasPendingActivity() const;

and return |true| until either fulfill() or reject() is called.  Until the async
status (success/error) is determined, this must stay alive.

You may want to verify this with haraken.

[Takashi Toyoshima, 2013/06/07 04:55:17]

I see.
I indirectly realize right hasPendingActivity() behavior by adding
setPendingActivity()/unsetPendingActivity() at proper places.

+
+    void fulfill();
+    void reject(DOMError*);
+
+private:
+    enum State {
+        Pending,
+        Accepted,
+        Rejected,
+        Invoked,
+    };
+
+    MIDIAccessPromise(ScriptExecutionContext*, const Dictionary&);
+
+    ScriptExecutionContext* m_context;

[Chris Rogers, 2013/06/07 04:27:25]

Since we inherit from ActiveDOMObject, I don't think it's necessary to keep
track of m_context, since scriptExecutionContext() is a method

So this member can be removed

[Takashi Toyoshima, 2013/06/07 04:55:17]

Thanks. I forget to remove this when I change this class to be ActiveDOMObject.
Done.

+    State m_state;
+    RefPtr<MIDISuccessCallback> m_successCallback;
+    RefPtr<MIDIErrorCallback> m_errorCallback;
+    OwnPtr<MIDIOptions> m_options;
+    RefPtr<DOMError> m_error;
+    RefPtr<MIDIAccess> m_access;
+};
+
+} // namespace WebCore
+
+#endif // MIDIAccessPromise_h