Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1333)

Issue 15994009: Match spec for font-weight: bolder|lighter (Closed)

Created:
7 years, 6 months ago by Timothy Loh
Modified:
7 years, 5 months ago
CC:
blink-reviews, jamesr, eae+blinkwatch, danakj, Rik, Stephen Chennney, jeez, pdr., ojan, Julie Parent
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

Match spec for font-weight: bolder|lighter Currently, bolder and lighter change font-weight in a non-compliant way The spec (http://www.w3.org/TR/css3-fonts/#bolderlighter) defines exactly what the computed values should be given the inherited weight values, so we should match those. The removed FIXME's for selecting the next lightest/heaviest weight from the used font family seems to refer to behaviour from CSS1 (http://www.w3.org/TR/CSS1/#font-weight), while this is replaced with a simpler procedure for resolving bolder and lighter in font weights in CSS2 (http://www.w3.org/TR/CSS2/fonts.html#propdef-font-weight) and CSS3 (link above). BUG=242041 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153116

Patch Set 1 #

Patch Set 2 : presubmit has svn error, maybe re-upload will fix? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -15 lines) Patch
A LayoutTests/css3/font-weight.html View 1 chunk +44 lines, -0 lines 0 comments Download
A LayoutTests/css3/font-weight-expected.txt View 1 chunk +42 lines, -0 lines 0 comments Download
M Source/core/platform/graphics/FontDescription.cpp View 3 chunks +1 line, -15 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Timothy Loh
7 years, 6 months ago (2013-06-05 14:07:11 UTC) #1
eseidel
lgtm, but ojan or jparent may be better reviewers for this? You might consider submitting ...
7 years, 6 months ago (2013-06-06 07:02:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/15994009/1
7 years, 6 months ago (2013-06-26 06:08:22 UTC) #3
Timothy Loh
Forgot about this change! ksakamoto came up with the exact same change to FontDescription.cpp since ...
7 years, 6 months ago (2013-06-26 06:10:21 UTC) #4
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=2340
7 years, 6 months ago (2013-06-26 06:20:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/15994009/1
7 years, 6 months ago (2013-06-26 06:22:40 UTC) #6
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=2345
7 years, 6 months ago (2013-06-26 06:35:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/15994009/15001
7 years, 6 months ago (2013-06-26 06:37:50 UTC) #8
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=2350
7 years, 6 months ago (2013-06-26 06:48:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/15994009/15001
7 years, 5 months ago (2013-06-27 03:41:49 UTC) #10
commit-bot: I haz the power
7 years, 5 months ago (2013-06-27 04:57:07 UTC) #11
Message was sent while issue was closed.
Change committed as 153116

Powered by Google App Engine
This is Rietveld 408576698