Remove the optimized construct stub.

Remove the optimized construct stub.

R=mstarzinger@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=14946

[Toon Verwaest, 2013-06-04 16:42:38]

PTAL

[Michael Starzinger, 2013-06-05 08:34:04]

LGTM with two nits and one real comments in the objects.h file. Code-b-gone!

https://codereview.chromium.org/15993016/diff/3001/src/heap.cc
File src/heap.cc (right):

https://codereview.chromium.org/15993016/diff/3001/src/heap.cc#newcode4201
src/heap.cc:4201: ASSERT(in_object_properties <=
Map::kMaxPreAllocatedPropertyFields);
Both the assert and the five lines of comments above have become obsolete, let's
drop that as well.

https://codereview.chromium.org/15993016/diff/3001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/15993016/diff/3001/src/objects.h#newcode6330
src/objects.h:6330: kCompilerHintsOffset + kPointerSize,
This should be "kInitialMapOffset + kPointerSize" as it should only include the
pointer fields, not the SMI fields.

https://codereview.chromium.org/15993016/diff/3001/test/mjsunit/bugs/618.js
File test/mjsunit/bugs/618.js (left):

https://codereview.chromium.org/15993016/diff/3001/test/mjsunit/bugs/618.js#o...
test/mjsunit/bugs/618.js:1: // Copyright 2010 the V8 project authors. All rights
reserved.
Instead of deleting this file, let's move it to mjsunit/regress/regress-618.js
instead.

[Toon Verwaest, 2013-06-05 08:41:42]

Addressed comments

https://codereview.chromium.org/15993016/diff/3001/src/heap.cc
File src/heap.cc (right):

https://codereview.chromium.org/15993016/diff/3001/src/heap.cc#newcode4201
src/heap.cc:4201: ASSERT(in_object_properties <=
Map::kMaxPreAllocatedPropertyFields);
On 2013/06/05 08:34:04, Michael Starzinger wrote:
> Both the assert and the five lines of comments above have become obsolete,
let's
> drop that as well.

Done.

https://codereview.chromium.org/15993016/diff/3001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/15993016/diff/3001/src/objects.h#newcode6330
src/objects.h:6330: kCompilerHintsOffset + kPointerSize,
On 2013/06/05 08:34:04, Michael Starzinger wrote:
> This should be "kInitialMapOffset + kPointerSize" as it should only include
the
> pointer fields, not the SMI fields.

Done.

https://codereview.chromium.org/15993016/diff/3001/test/mjsunit/bugs/618.js
File test/mjsunit/bugs/618.js (left):

https://codereview.chromium.org/15993016/diff/3001/test/mjsunit/bugs/618.js#o...
test/mjsunit/bugs/618.js:1: // Copyright 2010 the V8 project authors. All rights
reserved.
On 2013/06/05 08:34:04, Michael Starzinger wrote:
> Instead of deleting this file, let's move it to mjsunit/regress/regress-618.js
> instead.

Done.

[Toon Verwaest, 2013-06-05 08:43:42]

Committed patchset #3 manually as r14946 (presubmit successful).