Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 15991003: Avoid redundant ceilToFloat call in RenderBlock (Closed)

Created:
7 years, 7 months ago by Eric Willigers
Modified:
7 years, 6 months ago
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

Avoid redundant ceilToFloat call in RenderBlock R=leviw@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152006

Patch Set 1 #

Total comments: 1

Patch Set 2 : ceiledTextIndent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M Source/core/rendering/RenderBlock.cpp View 1 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Eric Willigers
7 years, 7 months ago (2013-05-28 00:20:20 UTC) #1
Eric Willigers
7 years, 6 months ago (2013-06-03 04:11:22 UTC) #2
Julien - ping for review
Assuming the try bots are good, lgtm! https://codereview.chromium.org/15991003/diff/1/Source/core/rendering/RenderBlock.cpp File Source/core/rendering/RenderBlock.cpp (right): https://codereview.chromium.org/15991003/diff/1/Source/core/rendering/RenderBlock.cpp#newcode6106 Source/core/rendering/RenderBlock.cpp:6106: float ti ...
7 years, 6 months ago (2013-06-06 19:46:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericwilligers@chromium.org/15991003/7001
7 years, 6 months ago (2013-06-07 00:38:04 UTC) #4
commit-bot: I haz the power
7 years, 6 months ago (2013-06-07 07:57:49 UTC) #5
Message was sent while issue was closed.
Change committed as 152006

Powered by Google App Engine
This is Rietveld 408576698