Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 15990006: Make clone(2) restrictions work on ARM. (Closed)

Created:
7 years, 6 months ago by Jorge Lucangeli Obes
Modified:
7 years, 6 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jln+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Make clone(2) restrictions work on ARM. Fix some style nits while there. TEST=Robot Unicorn Attack. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203049

Patch Set 1 #

Patch Set 2 : Forgot to add some changes. #

Patch Set 3 : Restore amd64 if guard. #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -21 lines) Patch
M content/common/sandbox_seccomp_bpf_linux.cc View 1 2 14 chunks +22 lines, -21 lines 3 comments Download

Messages

Total messages: 6 (0 generated)
Jorge Lucangeli Obes
Weird combination of flags, but fixes ARM.
7 years, 6 months ago (2013-05-29 17:51:00 UTC) #1
Chris Evans
LGTM with notes. https://chromiumcodereview.appspot.com/15990006/diff/4001/content/common/sandbox_seccomp_bpf_linux.cc File content/common/sandbox_seccomp_bpf_linux.cc (right): https://chromiumcodereview.appspot.com/15990006/diff/4001/content/common/sandbox_seccomp_bpf_linux.cc#newcode1251 content/common/sandbox_seccomp_bpf_linux.cc:1251: ErrorCode RestrictMmapFlags(Sandbox* sandbox) { There's quite ...
7 years, 6 months ago (2013-05-29 19:54:12 UTC) #2
Jorge Lucangeli Obes
https://chromiumcodereview.appspot.com/15990006/diff/4001/content/common/sandbox_seccomp_bpf_linux.cc File content/common/sandbox_seccomp_bpf_linux.cc (right): https://chromiumcodereview.appspot.com/15990006/diff/4001/content/common/sandbox_seccomp_bpf_linux.cc#newcode1599 content/common/sandbox_seccomp_bpf_linux.cc:1599: case __NR_clone: On 2013/05/29 19:54:13, Chris Evans wrote: > ...
7 years, 6 months ago (2013-05-29 19:57:22 UTC) #3
jln (very slow on Chromium)
lgtm
7 years, 6 months ago (2013-05-29 20:17:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jorgelo@chromium.org/15990006/4001
7 years, 6 months ago (2013-05-29 20:25:21 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-05-30 03:47:05 UTC) #6
Message was sent while issue was closed.
Change committed as 203049

Powered by Google App Engine
This is Rietveld 408576698