Issue 15989002: Add UpdateOperationTest for drive::file_system::UpdateOperationTest.

Issue 15989002: Add UpdateOperationTest for drive::file_system::UpdateOperationTest. (Closed)

Created:
7 years, 7 months ago by kinaba

Modified:
7 years, 6 months ago

Reviewers:
hidehiko

CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik+watch_chromium.org, oshima+watch_chromium.org, tfarina, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add UpdateOperationTest for drive::file_system::UpdateOperationTest. Compared to the existing test, it checks that the update is indeed reflected to the layer of DriveService. BUG=223865 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202387

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase + Reflect review comment #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+118 lines, -102 lines)			Patch
M	chrome/browser/chromeos/drive/file_system/operation_test_base.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A	chrome/browser/chromeos/drive/file_system/update_operation_unittest.cc	View	1	1 chunk	+113 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system_unittest.cc	View	1	2 chunks	+0 lines, -102 lines	0 comments	Download
M	chrome/browser/google_apis/fake_drive_service.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

hidehiko

lgtm https://codereview.chromium.org/15989002/diff/1/chrome/browser/chromeos/drive/file_system/update_operation_unittest.cc File chrome/browser/chromeos/drive/file_system/update_operation_unittest.cc (right): https://codereview.chromium.org/15989002/diff/1/chrome/browser/chromeos/drive/file_system/update_operation_unittest.cc#newcode50 chrome/browser/chromeos/drive/file_system/update_operation_unittest.cc:50: cache()->StoreOnUIThread( nit: How about reassign a value other ...

7 years, 7 months ago (2013-05-24 12:45:42 UTC) #2

kinaba

https://codereview.chromium.org/15989002/diff/1/chrome/browser/chromeos/drive/file_system/update_operation_unittest.cc File chrome/browser/chromeos/drive/file_system/update_operation_unittest.cc (right): https://codereview.chromium.org/15989002/diff/1/chrome/browser/chromeos/drive/file_system/update_operation_unittest.cc#newcode50 chrome/browser/chromeos/drive/file_system/update_operation_unittest.cc:50: cache()->StoreOnUIThread( On 2013/05/24 12:45:42, hidehiko wrote: > nit: How ...

7 years, 6 months ago (2013-05-27 01:33:52 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/15989002/4001

7 years, 6 months ago (2013-05-27 01:41:19 UTC) #4

bcwhite

I believe you have the wrong bug # for this CL. 223865 is about sign-in-page ...

7 years, 6 months ago (2013-05-27 14:40:16 UTC) #6

kinaba

7 years, 6 months ago (2013-05-27 14:45:07 UTC) #7

Message was sent while issue was closed.

On 2013/05/27 14:40:16, bcwhite wrote:
> I believe you have the wrong bug # for this CL.
> 223865 is about sign-in-page redirection.

Agh, sorry. It was 223856. I was wondering why bugdroid didn't come to the bug
page ..:(.
Thanks for letting me know.

Expand Messages | Collapse Messages