Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Unified Diff: src/hydrogen-instructions.cc

Issue 15988005: Only allow non-double if the observed representations are int32. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/hydrogen-instructions.cc
diff --git a/src/hydrogen-instructions.cc b/src/hydrogen-instructions.cc
index eadac83ed1be76f57d5dfef1c01e151702874a00..069b3f2cbd0d314c72701af391fb1e998ef27ada 100644
--- a/src/hydrogen-instructions.cc
+++ b/src/hydrogen-instructions.cc
@@ -2460,10 +2460,12 @@ void HCompareIDAndBranch::InferRepresentation(HInferRepresentation* h_infer) {
Representation observed_right = observed_input_representation(1);
Representation rep = Representation::Smi();
- if (!left_rep.IsTagged()) rep = rep.generalize(left_rep);
- if (!right_rep.IsTagged()) rep = rep.generalize(right_rep);
- if (!observed_left.IsTagged()) rep = rep.generalize(observed_left);
- if (!observed_right.IsTagged()) rep = rep.generalize(observed_right);
+ if (observed_left.IsInteger32() && observed_right.IsInteger32()) {
+ if (!left_rep.IsTagged()) rep = rep.generalize(left_rep);
+ if (!right_rep.IsTagged()) rep = rep.generalize(right_rep);
+ } else {
+ rep = Representation::Double();
+ }
if (rep.IsDouble()) {
// According to the ES5 spec (11.9.3, 11.8.5), Equality comparisons (==, ===
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698