Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: chrome/browser/translate/translate_manager_metrics.cc

Issue 15987004: Translate: Filter and record languages whose names Chrome doesn't show (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/translate/translate_manager_metrics.cc
diff --git a/chrome/browser/translate/translate_manager_metrics.cc b/chrome/browser/translate/translate_manager_metrics.cc
index 0098c74a4f0a140cdced48d33318e0dab20b5ab1..3c234c916f9cbc3c58d053ba1a3f88f432eec451 100644
--- a/chrome/browser/translate/translate_manager_metrics.cc
+++ b/chrome/browser/translate/translate_manager_metrics.cc
@@ -23,6 +23,8 @@ const char kTranslateServerReportedUnsupportedLanguage[] =
"Translate.ServerReportedUnsupportedLanguage";
const char kTranslateUnsupportedLanguageAtInitiation[] =
"Translate.UnsupportedLanguageAtInitiation";
+const char kTranslateUndisplayableLanguage[] =
+ "Translate.UndisplayableLanguage";
struct MetricsEntry {
TranslateManagerMetrics::MetricsNameIndex index;
@@ -39,6 +41,8 @@ const MetricsEntry kMetricsEntries[] = {
kTranslateServerReportedUnsupportedLanguage },
{ TranslateManagerMetrics::UMA_UNSUPPORTED_LANGUAGE_AT_INITIATION,
kTranslateUnsupportedLanguageAtInitiation },
+ { TranslateManagerMetrics::UMA_UNDISPLAYABLE_LANGUAGE,
+ kTranslateUndisplayableLanguage },
};
COMPILE_ASSERT(arraysize(kMetricsEntries) == TranslateManagerMetrics::UMA_MAX,
@@ -68,6 +72,12 @@ void ReportUnsupportedLanguageAtInitiation(const std::string& language) {
language_code);
}
+void ReportUndisplayableLanguage(const std::string& language) {
+ int language_code = LanguageUsageMetrics::ToLanguageCode(language);
+ UMA_HISTOGRAM_SPARSE_SLOWLY(kTranslateUndisplayableLanguage,
+ language_code);
+}
+
const char* GetMetricsName(MetricsNameIndex index) {
for (size_t i = 0; i < arraysize(kMetricsEntries); ++i) {
if (kMetricsEntries[i].index == index)

Powered by Google App Engine
This is Rietveld 408576698