Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 15984004: Update cc/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed)

Created:
7 years, 6 months ago by Ryan Sleevi
Modified:
7 years, 6 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, feature-media-reviews_chromium.org, cc-bugs_chromium.org
Visibility:
Public.

Description

Update cc/ to use scoped_refptr<T>::get() rather than implicit "operator T*" Linux fixes BUG=110610 TBR=enne Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203584

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+259 lines, -361 lines) Patch
M cc/animation/layer_animation_controller_unittest.cc View 7 chunks +9 lines, -9 lines 0 comments Download
M cc/base/worker_pool.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M cc/base/worker_pool_perftest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/base/worker_pool_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/content_layer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/layers/contents_scaling_layer_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M cc/layers/image_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/layer.h View 1 chunk +4 lines, -3 lines 0 comments Download
M cc/layers/layer.cc View 10 chunks +18 lines, -18 lines 0 comments Download
M cc/layers/layer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/nine_patch_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/nine_patch_layer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/picture_layer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layers/picture_layer_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layers/scrollbar_layer.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M cc/layers/scrollbar_layer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/layers/solid_color_layer_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/texture_layer_unittest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M cc/layers/tiled_layer_unittest.cc View 2 chunks +12 lines, -12 lines 0 comments Download
M cc/layers/video_layer_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/output/gl_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/picture.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M cc/resources/picture_layer_tiling.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/picture_layer_tiling.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M cc/resources/picture_pile.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/picture_pile_impl.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M cc/resources/picture_pile_impl_unittest.cc View 20 chunks +53 lines, -159 lines 0 comments Download
M cc/resources/picture_unittest.cc View 11 chunks +23 lines, -34 lines 0 comments Download
M cc/resources/raster_worker_pool.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/raster_worker_pool.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/resource_provider.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/resources/tile_manager.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M cc/resources/video_resource_updater.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_layer_tree_host_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/test/layer_tree_pixel_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/layer_tree_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 7 chunks +12 lines, -12 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 11 chunks +23 lines, -13 lines 0 comments Download
M cc/trees/layer_tree_host_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_pixeltest_masks.cc View 9 chunks +11 lines, -11 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_animation.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_context.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/trees/occlusion_tracker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/single_thread_proxy.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/trees/thread_proxy.cc View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ryan Sleevi
TBR=enne I'm explicitly TBRing this to you, rather than Darin, because there is a set ...
7 years, 6 months ago (2013-05-31 23:55:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/15984004/1
7 years, 6 months ago (2013-05-31 23:56:03 UTC) #2
enne (OOO)
lgtm I personally don't see any harm in raw pointers implicitly coming from refptrs, since ...
7 years, 6 months ago (2013-06-01 03:22:24 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-01 04:52:31 UTC) #4
Message was sent while issue was closed.
Change committed as 203584

Powered by Google App Engine
This is Rietveld 408576698