Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Side by Side Diff: chrome/common/extensions/command.cc

Issue 15981010: Use a direct include of strings headers in chrome/common/, part 1. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/common/extensions/command.h ('k') | chrome/common/extensions/command_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/command.h" 5 #include "chrome/common/extensions/command.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/string_util.h"
9 #include "base/strings/string_number_conversions.h" 8 #include "base/strings/string_number_conversions.h"
10 #include "base/strings/string_split.h" 9 #include "base/strings/string_split.h"
10 #include "base/strings/string_util.h"
11 #include "base/values.h" 11 #include "base/values.h"
12 #include "chrome/common/extensions/extension.h" 12 #include "chrome/common/extensions/extension.h"
13 #include "chrome/common/extensions/extension_manifest_constants.h" 13 #include "chrome/common/extensions/extension_manifest_constants.h"
14 #include "extensions/common/error_utils.h" 14 #include "extensions/common/error_utils.h"
15 #include "grit/generated_resources.h" 15 #include "grit/generated_resources.h"
16 #include "ui/base/l10n/l10n_util.h" 16 #include "ui/base/l10n/l10n_util.h"
17 17
18 namespace errors = extension_manifest_errors; 18 namespace errors = extension_manifest_errors;
19 namespace keys = extension_manifest_keys; 19 namespace keys = extension_manifest_keys;
20 namespace values = extension_manifest_values; 20 namespace values = extension_manifest_values;
(...skipping 436 matching lines...) Expand 10 before | Expand all | Expand 10 after
457 extension_data->SetString("description", command_description); 457 extension_data->SetString("description", command_description);
458 extension_data->SetBoolean("active", active); 458 extension_data->SetBoolean("active", active);
459 extension_data->SetString("keybinding", accelerator().GetShortcutText()); 459 extension_data->SetString("keybinding", accelerator().GetShortcutText());
460 extension_data->SetString("command_name", command_name()); 460 extension_data->SetString("command_name", command_name());
461 extension_data->SetString("extension_id", extension->id()); 461 extension_data->SetString("extension_id", extension->id());
462 462
463 return extension_data; 463 return extension_data;
464 } 464 }
465 465
466 } // namespace extensions 466 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/common/extensions/command.h ('k') | chrome/common/extensions/command_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698