Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 15979030: [chromedriver] Add some simple perf benchmarks. (Closed)

Created:
7 years, 6 months ago by kkania
Modified:
7 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[chromedriver] Add some simple perf benchmarks. These always pass and just output the results for now. BUG=chromedriver:10 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204037

Patch Set 1 : . #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -19 lines) Patch
M chrome/test/chromedriver/run_all_tests.py View 7 chunks +39 lines, -16 lines 0 comments Download
M chrome/test/chromedriver/run_py_tests.py View 1 4 chunks +82 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kkania
7 years, 6 months ago (2013-06-04 18:25:39 UTC) #1
chrisgao (Use stgao instead)
lgtm with nit. But please commit after references are checked in. https://codereview.chromium.org/15979030/diff/6001/chrome/test/chromedriver/run_py_tests.py File chrome/test/chromedriver/run_py_tests.py (right): ...
7 years, 6 months ago (2013-06-04 20:33:27 UTC) #2
kkania
https://codereview.chromium.org/15979030/diff/6001/chrome/test/chromedriver/run_py_tests.py File chrome/test/chromedriver/run_py_tests.py (right): https://codereview.chromium.org/15979030/diff/6001/chrome/test/chromedriver/run_py_tests.py#newcode687 chrome/test/chromedriver/run_py_tests.py:687: help='Path to the chromedriver server') On 2013/06/04 20:33:27, chrisgao ...
7 years, 6 months ago (2013-06-04 20:49:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkania@chromium.org/15979030/5004
7 years, 6 months ago (2013-06-04 20:54:19 UTC) #4
commit-bot: I haz the power
7 years, 6 months ago (2013-06-04 20:54:36 UTC) #5
Message was sent while issue was closed.
Change committed as 204037

Powered by Google App Engine
This is Rietveld 408576698