Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(925)

Issue 15979023: Redo r203907 base_unittests.exe to use allocator shims (Closed)

Created:
7 years, 6 months ago by Will Harris
Modified:
7 years, 6 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, dmikurube+memory_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Redo r203907 base_unittests.exe to use alloactor shims Previous commit r203907 broke VS2012 build because in VS7.1, the new array operator is now in newaopnt.obj and not newopnt.obj. This commit modifies prep_libc.py to correctly pull the newaopnt.obj from libcmt.lib so there is no symbol clash. See also crrev.com/15674003 and crrev.com/16154020 BUG=242304 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205115

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M base/allocator/prep_libc.py View 1 chunk +1 line, -1 line 0 comments Download
M base/base.gyp View 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Will Harris
This is a redo of previous commit that was reverted because static builds failed a ...
7 years, 6 months ago (2013-06-05 19:35:15 UTC) #1
jar (doing other things)
lgtm
7 years, 6 months ago (2013-06-06 15:40:18 UTC) #2
Will Harris
Thanks - I'll hold off committing this until I know for sure I'm not going ...
7 years, 6 months ago (2013-06-06 17:50:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/15979023/1
7 years, 6 months ago (2013-06-09 09:36:34 UTC) #4
commit-bot: I haz the power
7 years, 6 months ago (2013-06-09 12:57:41 UTC) #5
Message was sent while issue was closed.
Change committed as 205115

Powered by Google App Engine
This is Rietveld 408576698