[Android WebView] Provide a minimal error description for nav errors

[Android WebView] Provide a minimal error description for nav errors

Since not all net error codes can be mapped onto Android error codes,
at least provide a minimal description for the client.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204002

[mkosiba (inactive), 2013-06-04 10:19:54]

nice! did you fix this because of a specific error case that didn't have an
error message? Do you think it makes sense to add a ClientOnReceivedErrorTest
for that case?

[benm (inactive), 2013-06-04 10:24:50]

lgtm

https://codereview.chromium.org/15979017/diff/1/android_webview/renderer/aw_c...
File android_webview/renderer/aw_content_renderer_client.cc (right):

https://codereview.chromium.org/15979017/diff/1/android_webview/renderer/aw_c...
android_webview/renderer/aw_content_renderer_client.cc:74:
string16(ASCIIToUTF16(net::ErrorToString(error.reason)));
is the string16 ctor needed?

[mnaganov (inactive), 2013-06-04 10:43:04]

> nice! did you fix this because of a specific error case that didn't have an
error message? Do you think it makes sense to add a ClientOnReceivedErrorTest
for that case?

Yes, for the cache miss error. Added a test.

https://codereview.chromium.org/15979017/diff/1/android_webview/renderer/aw_c...
File android_webview/renderer/aw_content_renderer_client.cc (right):

https://codereview.chromium.org/15979017/diff/1/android_webview/renderer/aw_c...
android_webview/renderer/aw_content_renderer_client.cc:74:
string16(ASCIIToUTF16(net::ErrorToString(error.reason)));
On 2013/06/04 10:24:50, benm wrote:
> is the string16 ctor needed?

Actually not, removed.

[commit-bot: I haz the power, 2013-06-04 10:43:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mnaganov@chromium.org/15979017/5001

[joth, 2013-06-04 17:43:19]

lgtm

https://chromiumcodereview.appspot.com/15979017/diff/5001/android_webview/jav...
File
android_webview/javatests/src/org/chromium/android_webview/test/ClientOnReceivedErrorTest.java
(right):

https://chromiumcodereview.appspot.com/15979017/diff/5001/android_webview/jav...
android_webview/javatests/src/org/chromium/android_webview/test/ClientOnReceivedErrorTest.java:137:
assertNotNull(onReceivedErrorHelper.getDescription());
assert it's not empty string too?

[commit-bot: I haz the power, 2013-06-04 18:06:21]

Change committed as 204002

[mnaganov (inactive), 2013-06-05 09:28:25]

https://codereview.chromium.org/15979017/diff/5001/android_webview/javatests/...
File
android_webview/javatests/src/org/chromium/android_webview/test/ClientOnReceivedErrorTest.java
(right):

https://codereview.chromium.org/15979017/diff/5001/android_webview/javatests/...
android_webview/javatests/src/org/chromium/android_webview/test/ClientOnReceivedErrorTest.java:137:
assertNotNull(onReceivedErrorHelper.getDescription());
On 2013/06/04 17:43:19, joth wrote:
> assert it's not empty string too?

Bingo! The code wasn't actually working. See
https://codereview.chromium.org/16441002/