Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 15978002: Add plugin list for Chrome for TV (Closed)

Created:
7 years, 7 months ago by kjyoun
Modified:
7 years, 7 months ago
CC:
chromium-reviews, arv+watch_chromium.org, tv-nikita_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add plugin list for Chrome for TV Previously, Chrome for TV used plugin list of linux, though it was not right one, since Android used resource for linux by default. But, with https://codereview.chromium.org/14834011, Android and Linux resource was separated cleanly. As a result, Chrome for TV, based on Android, needs its own plugin list. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202492

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M build/common.gypi View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 1 chunk +4 lines, -1 line 2 comments Download
A chrome/browser/resources/plugin_metadata/plugins_tv.json View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
kjyoun
Can you review this CL?
7 years, 7 months ago (2013-05-24 05:50:58 UTC) #1
Bernhard Bauer
https://codereview.chromium.org/15978002/diff/1001/chrome/browser/browser_resources.grd File chrome/browser/browser_resources.grd (right): https://codereview.chromium.org/15978002/diff/1001/chrome/browser/browser_resources.grd#newcode194 chrome/browser/browser_resources.grd:194: <include name="IDR_PLUGIN_DB_JSON" file="resources\plugin_metadata\plugins_tv.json" type="BINDATA" /> Is "tv" a platform? ...
7 years, 7 months ago (2013-05-24 06:02:54 UTC) #2
kjyoun
https://codereview.chromium.org/15978002/diff/1001/chrome/browser/browser_resources.grd File chrome/browser/browser_resources.grd (right): https://codereview.chromium.org/15978002/diff/1001/chrome/browser/browser_resources.grd#newcode194 chrome/browser/browser_resources.grd:194: <include name="IDR_PLUGIN_DB_JSON" file="resources\plugin_metadata\plugins_tv.json" type="BINDATA" /> Currently, tv itself is ...
7 years, 7 months ago (2013-05-24 08:19:22 UTC) #3
Torne
LGTM
7 years, 7 months ago (2013-05-24 10:09:30 UTC) #4
Bernhard Bauer
LGTM
7 years, 7 months ago (2013-05-24 15:55:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kjyoun@google.com/15978002/1001
7 years, 7 months ago (2013-05-27 01:00:53 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=5068
7 years, 7 months ago (2013-05-27 01:50:22 UTC) #7
kjyoun
Hi Scott Can you review this CL?
7 years, 7 months ago (2013-05-27 01:55:07 UTC) #8
sky
LGTM
7 years, 7 months ago (2013-05-27 15:46:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kjyoun@google.com/15978002/1001
7 years, 7 months ago (2013-05-28 00:07:00 UTC) #10
kjyoun
Thanks for the review! On 2013/05/28 00:07:00, I haz the power (commit-bot) wrote: > CQ ...
7 years, 7 months ago (2013-05-28 00:18:51 UTC) #11
commit-bot: I haz the power
7 years, 7 months ago (2013-05-28 03:20:39 UTC) #12
Message was sent while issue was closed.
Change committed as 202492

Powered by Google App Engine
This is Rietveld 408576698