Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: chrome/browser/chromeos/drive/file_cache.h

Issue 15974004: drive: Rewrite UpdateOpreation to access cache/metadata on the blocking pool (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove ClearDirtyOnUIThread Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/drive/file_cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/drive/file_cache.h
diff --git a/chrome/browser/chromeos/drive/file_cache.h b/chrome/browser/chromeos/drive/file_cache.h
index bef7635c9ef455c2c266caaa94b7947b93fa4bcd..42cb0ba9c8e3fa21738f84339361caaabc4779d5 100644
--- a/chrome/browser/chromeos/drive/file_cache.h
+++ b/chrome/browser/chromeos/drive/file_cache.h
@@ -262,18 +262,9 @@ class FileCache {
const std::string& md5,
const FileOperationCallback& callback);
- // Modifies cache state, which involves the following:
- // - moves |source_path| to |dest_path| in persistent dir if
- // file is pinned or tmp dir otherwise, where |source_path| has .local
- // extension and |dest_path| has .<md5> extension
- // - deletes symlink in outgoing dir
- // - if file is pinned, updates symlink in pinned dir to reference
- // |dest_path|
- // |callback| must not be null.
- // Must be called on the UI thread.
- void ClearDirtyOnUIThread(const std::string& resource_id,
- const std::string& md5,
- const FileOperationCallback& callback);
+ // Clears dirty state of the specified entry.
+ FileError ClearDirty(const std::string& resource_id,
+ const std::string& md5);
// Runs Remove() on |blocking_task_runner_| and runs |callback| with the
// result.
@@ -381,10 +372,6 @@ class FileCache {
FileError MarkDirty(const std::string& resource_id,
const std::string& md5);
- // Used to implement ClearDirtyOnUIThread.
- FileError ClearDirty(const std::string& resource_id,
- const std::string& md5);
-
// Used to implement ClearAllOnUIThread.
bool ClearAll();
« no previous file with comments | « no previous file | chrome/browser/chromeos/drive/file_cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698