Issue 15974004: drive: Rewrite UpdateOpreation to access cache/metadata on the blocking pool

Issue 15974004: drive: Rewrite UpdateOpreation to access cache/metadata on the blocking pool (Closed)

Created:
7 years, 6 months ago by hashimoto

Modified:
7 years, 6 months ago

Reviewers:
commit-bot: I haz the power, kinaba

CC:
chromium-reviews, nkostylev+watch_chromium.org, tfarina, oshima+watch_chromium.org, tzik+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

drive: Rewrite UpdateOpreation to access cache/metadata on the blocking pool Stop using *OnUIThread methods of ResourceMetadata and FileCache from UpdateOperation. Make FileCache::ClearDirty public. BUG=231221, 231222 TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202532

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Remove ClearDirtyOnUIThread #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+189 lines, -176 lines)			Patch
M	chrome/browser/chromeos/drive/file_cache.h	View	1	2 chunks	+3 lines, -16 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_cache.cc	View	1	2 chunks	+55 lines, -69 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_cache_unittest.cc	View	1	1 chunk	+6 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/operations.cc	View		1 chunk	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/update_operation.h	View		3 chunks	+15 lines, -17 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/update_operation.cc	View		5 chunks	+100 lines, -68 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/update_operation_unittest.cc	View		1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

kinaba

lgtm! https://codereview.chromium.org/15974004/diff/2001/chrome/browser/chromeos/drive/file_cache.h File chrome/browser/chromeos/drive/file_cache.h (right): https://codereview.chromium.org/15974004/diff/2001/chrome/browser/chromeos/drive/file_cache.h#newcode270 chrome/browser/chromeos/drive/file_cache.h:270: const FileOperationCallback& callback); Looks like UpdateOperation is the ...

7 years, 6 months ago (2013-05-28 06:29:40 UTC) #2

hashimoto

https://codereview.chromium.org/15974004/diff/2001/chrome/browser/chromeos/drive/file_cache.h File chrome/browser/chromeos/drive/file_cache.h (right): https://codereview.chromium.org/15974004/diff/2001/chrome/browser/chromeos/drive/file_cache.h#newcode270 chrome/browser/chromeos/drive/file_cache.h:270: const FileOperationCallback& callback); On 2013/05/28 06:29:40, kinaba wrote: > ...

7 years, 6 months ago (2013-05-28 06:55:09 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/15974004/8001

7 years, 6 months ago (2013-05-28 08:00:10 UTC) #4

commit-bot: I haz the power

Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=118940

7 years, 6 months ago (2013-05-28 10:05:58 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/15974004/8001

7 years, 6 months ago (2013-05-28 10:13:39 UTC) #6

Message was sent while issue was closed.

Change committed as 202532

Expand Messages | Collapse Messages