Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 15974003: Fix candidate window initialization. (Closed)

Created:
7 years, 7 months ago by Seigo Nonaka
Modified:
7 years, 6 months ago
Reviewers:
Zachary Kuznia
CC:
chromium-reviews, nkostylev+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org, Yuki Shiino
Visibility:
Public.

Description

Fix candidate window initialization. OnConnected/OnDisconnected observer callback is not meaning anything on chromeos=1 build, so it calles automatically at the begging of input method initialization. However it is too early for CandidateWindowController to do initialization in OnConnected, so do initialization immediately if it is available. BUG=244322 TEST=Manually checked on ubuntu Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202592

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Seigo Nonaka
Hi Zach, could you take a look? This is not urgent or serious because this ...
7 years, 7 months ago (2013-05-28 05:29:19 UTC) #1
Zachary Kuznia
lgtm
7 years, 6 months ago (2013-05-28 14:37:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/15974003/1
7 years, 6 months ago (2013-05-28 15:04:35 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-05-28 17:22:16 UTC) #4
Message was sent while issue was closed.
Change committed as 202592

Powered by Google App Engine
This is Rietveld 408576698