Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(934)

Unified Diff: Source/core/rendering/RenderLayerCompositor.cpp

Issue 15973002: Remove NonCompositedContentHost -- Take 2 (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: adding back annotation. final rebase. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/RenderLayerCompositor.h ('k') | Source/core/rendering/RenderObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderLayerCompositor.cpp
diff --git a/Source/core/rendering/RenderLayerCompositor.cpp b/Source/core/rendering/RenderLayerCompositor.cpp
index 4b2c4d051671c05c0ec5db745f3f36cc37cec263..37bcbdc76bf4f45cd5454f3d765c5a9226ada6dc 100644
--- a/Source/core/rendering/RenderLayerCompositor.cpp
+++ b/Source/core/rendering/RenderLayerCompositor.cpp
@@ -1142,10 +1142,8 @@ void RenderLayerCompositor::frameViewDidScroll()
// If there's a scrolling coordinator that manages scrolling for this frame view,
// it will also manage updating the scroll layer position.
if (ScrollingCoordinator* scrollingCoordinator = this->scrollingCoordinator()) {
- if (scrollingCoordinator->coordinatesScrollingForFrameView(frameView))
- return;
if (Settings* settings = m_renderView->document()->settings()) {
- if (settings->compositedScrollingForFramesEnabled())
+ if (isMainFrame() || settings->compositedScrollingForFramesEnabled())
scrollingCoordinator->scrollableAreaScrollLayerDidChange(frameView);
}
}
@@ -1509,7 +1507,6 @@ bool RenderLayerCompositor::requiresOwnBackingStore(const RenderLayer* layer, co
RenderObject* renderer = layer->renderer();
if (compositingAncestorLayer
&& !(compositingAncestorLayer->backing()->graphicsLayer()->drawsContent()
- || compositingAncestorLayer->backing()->paintsIntoWindow()
|| compositingAncestorLayer->backing()->paintsIntoCompositedAncestor()))
return true;
@@ -2483,7 +2480,6 @@ void RenderLayerCompositor::attachRootLayer(RootLayerAttachment attachment)
}
m_rootLayerAttachment = attachment;
- rootLayerAttachmentChanged();
}
void RenderLayerCompositor::detachRootLayer()
@@ -2518,7 +2514,6 @@ void RenderLayerCompositor::detachRootLayer()
}
m_rootLayerAttachment = RootLayerUnattached;
- rootLayerAttachmentChanged();
}
void RenderLayerCompositor::updateRootLayerAttachment()
@@ -2531,15 +2526,6 @@ bool RenderLayerCompositor::isMainFrame() const
return !m_renderView->document()->ownerElement();
}
-void RenderLayerCompositor::rootLayerAttachmentChanged()
-{
- // The attachment can affect whether the RenderView layer's paintsIntoWindow() behavior,
- // so call updateGraphicsLayerGeometry() to udpate that.
- RenderLayer* layer = m_renderView->layer();
- if (RenderLayerBacking* backing = layer ? layer->backing() : 0)
- backing->updateDrawsContent();
-}
-
// IFrames are special, because we hook compositing layers together across iframe boundaries
// when both parent and iframe content are composited. So when this frame becomes composited, we have
// to use a synthetic style change to get the iframes into RenderLayers in order to allow them to composite.
« no previous file with comments | « Source/core/rendering/RenderLayerCompositor.h ('k') | Source/core/rendering/RenderObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698