Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 15971003: Connect DeleteSurroundingText signal. (Closed)

Created:
7 years, 7 months ago by Seigo Nonaka
Modified:
7 years, 6 months ago
Reviewers:
Zachary Kuznia
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Connect DeleteSurroundingText signal. Sorry for this regression, DeleteSurroundingText can't be used on actual device due to forgetting connecting signal. BUG=None TEST=Manually checked on link Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202448

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M chromeos/dbus/ibus/ibus_constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/dbus/ibus/ibus_input_context_client.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chromeos/dbus/ibus/ibus_input_context_client_unittest.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Seigo Nonaka
Hi Zach, could you take a look? Thank you.
7 years, 7 months ago (2013-05-24 06:41:45 UTC) #1
Zachary Kuznia
lgtm
7 years, 6 months ago (2013-05-27 05:36:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/15971003/4001
7 years, 6 months ago (2013-05-27 13:39:03 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-05-27 17:21:51 UTC) #4
Message was sent while issue was closed.
Change committed as 202448

Powered by Google App Engine
This is Rietveld 408576698