Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 15970004: Fix a couple of minor bugs with build/sanitize-png-files.sh (Closed)

Created:
7 years, 6 months ago by benwells
Modified:
7 years, 6 months ago
Reviewers:
oshima
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Fix a couple of minor bugs with build/sanitize-png-files.sh The bugs fixed are: - programs required for -o2 weren't checked for when using -o2 but were checked for lower -o levels. - if no savings could be found the results printed at the end were confusing and the script had a divide by zero error. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203051

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M build/sanitize-png-files.sh View 2 chunks +13 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
benwells
7 years, 6 months ago (2013-05-29 08:02:53 UTC) #1
oshima
lgtm thank you for fixing them!
7 years, 6 months ago (2013-05-29 14:35:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/15970004/1
7 years, 6 months ago (2013-05-30 01:32:53 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-05-30 03:56:56 UTC) #4
Message was sent while issue was closed.
Change committed as 203051

Powered by Google App Engine
This is Rietveld 408576698