chrome/browser/android/chrome_jni_registrar.cc - Issue 1596713003: Discourage creation of Java infobars without InfoBarDelegates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/chrome_jni_registrar.cc

Issue 1596713003: Discourage creation of Java infobars without InfoBarDelegates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebasing Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarTest2.java ('k') | chrome/browser/ui/android/infobars/simple_confirm_infobar_builder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/chrome_jni_registrar.cc

diff --git a/chrome/browser/android/chrome_jni_registrar.cc b/chrome/browser/android/chrome_jni_registrar.cc

index ec04fc9b4bd3548eb0dadfbbb1c0c70edf616d23..30aab4c59eb583e4c493e3b4cd2fc5d467160ce0 100644

--- a/chrome/browser/android/chrome_jni_registrar.cc

+++ b/chrome/browser/android/chrome_jni_registrar.cc

@@ -141,6 +141,7 @@

#include "chrome/browser/ui/android/infobars/infobar_android.h"

#include "chrome/browser/ui/android/infobars/infobar_container_android.h"

#include "chrome/browser/ui/android/infobars/save_password_infobar.h"

+#include "chrome/browser/ui/android/infobars/simple_confirm_infobar_builder.h"

#include "chrome/browser/ui/android/infobars/translate_infobar.h"

#include "chrome/browser/ui/android/javascript_app_modal_dialog_android.h"

#include "chrome/browser/ui/android/omnibox/omnibox_url_emphasizer.h"

@@ -281,6 +282,7 @@ static base::android::RegistrationMethod kChromeRegisteredMethods[] = {

{"InterestsService", InterestsService::Register},

{"InvalidationServiceFactory",

invalidation::InvalidationServiceFactoryAndroid::Register},

+ {"SimpleConfirmInfoBarBuilder", RegisterSimpleConfirmInfoBarBuilder},

{"ShortcutHelper", ShortcutHelper::RegisterShortcutHelper},

{"IntentHelper", RegisterIntentHelper},

{"JavaExceptionReporter", RegisterJavaExceptionReporterJni},