chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java - Issue 1596713003: Discourage creation of Java infobars without InfoBarDelegates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java

Issue 1596713003: Discourage creation of Java infobars without InfoBarDelegates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebasing Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/infobar/SimpleConfirmInfoBarBuilder.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarContainerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java

index 82bbb7f6a718d51fd6f20d4e0d44d9284f97166d..d29f9f3c4ab65478858e08e93271905032e2b944 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java

@@ -55,7 +55,7 @@ public class TranslateInfoBar extends InfoBar implements SubPanelListener {

private TranslateInfoBar(int infoBarType, String sourceLanguageCode, String targetLanguageCode,

boolean autoTranslatePair, boolean shouldShowNeverBar, boolean triggeredFromMenu,

String[] languages, String[] codes) {

- super(null, R.drawable.infobar_translate, null, null);

+ super(R.drawable.infobar_translate, null, null);

assert languages.length == codes.length;

ArrayList<TranslateOptions.TranslateLanguagePair> languageList =