chrome/android/java/src/org/chromium/chrome/browser/infobar/SavePasswordInfoBar.java - Issue 1596713003: Discourage creation of Java infobars without InfoBarDelegates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/SavePasswordInfoBar.java

Issue 1596713003: Discourage creation of Java infobars without InfoBarDelegates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebasing Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/infobar/MessageInfoBar.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/infobar/SimpleConfirmInfoBarBuilder.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/SavePasswordInfoBar.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/SavePasswordInfoBar.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/SavePasswordInfoBar.java

index eae9bb15e666bf65198c2662cfc75fbfa887eecd..74bb57faef8eb3cc5ca7e047699644a60af3de55 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/SavePasswordInfoBar.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/SavePasswordInfoBar.java

@@ -36,7 +36,7 @@ public class SavePasswordInfoBar extends ConfirmInfoBar {

private SavePasswordInfoBar(int iconDrawbleId, String message, int titleLinkStart,

int titleLinkEnd, String primaryButtonText, String secondaryButtonText,

String firstRunExperienceMessage) {

- super(null, iconDrawbleId, null, message, null, primaryButtonText, secondaryButtonText);

+ super(iconDrawbleId, null, message, null, primaryButtonText, secondaryButtonText);

mTitleLinkRangeStart = titleLinkStart;

mTitleLinkRangeEnd = titleLinkEnd;

mTitle = message;