chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBarAndroid.java - Issue 1596713003: Discourage creation of Java infobars without InfoBarDelegates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBarAndroid.java

Issue 1596713003: Discourage creation of Java infobars without InfoBarDelegates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebasing Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/infobar/AutoSigninFirstRunInfoBar.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBarAndroid.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBarAndroid.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBarAndroid.java

index 950cb05028d9125a41f75a0678c6895a5c2552b7..2f9f40ff5b43646739d18242c5192736e3b57f99 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBarAndroid.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBarAndroid.java

@@ -43,7 +43,7 @@ public class AppBannerInfoBarAndroid extends ConfirmInfoBar implements View.OnCl

// Banner for native apps.

private AppBannerInfoBarAndroid(String appTitle, Bitmap iconBitmap, AppData data) {

- super(null, 0, iconBitmap, appTitle, null, data.installButtonText(), null);

+ super(0, iconBitmap, appTitle, null, data.installButtonText(), null);

mAppTitle = appTitle;

mAppData = data;

mAppUrl = null;

@@ -52,7 +52,7 @@ public class AppBannerInfoBarAndroid extends ConfirmInfoBar implements View.OnCl

// Banner for web apps.

private AppBannerInfoBarAndroid(String appTitle, Bitmap iconBitmap, String url) {

- super(null, 0, iconBitmap, appTitle, null, getAddToHomescreenText(), null);

+ super(0, iconBitmap, appTitle, null, getAddToHomescreenText(), null);

mAppTitle = appTitle;

mAppData = null;

mAppUrl = url;