Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1056)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeWindow.java

Issue 1596713003: Discourage creation of Java infobars without InfoBarDelegates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebasing Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeWindow.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeWindow.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeWindow.java
index 5f08710b8655ada2dd01bdc0048162b318f4cbd6..e65091795bfdf70575673fe96931d028e7c90590 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeWindow.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeWindow.java
@@ -6,7 +6,8 @@ package org.chromium.chrome.browser;
import android.app.Activity;
-import org.chromium.chrome.browser.infobar.MessageInfoBar;
+import org.chromium.chrome.browser.infobar.InfoBarIdentifier;
+import org.chromium.chrome.browser.infobar.SimpleConfirmInfoBarBuilder;
import org.chromium.chrome.browser.tab.Tab;
import org.chromium.ui.base.ActivityWindowAndroid;
@@ -35,10 +36,8 @@ public class ChromeWindow extends ActivityWindowAndroid {
Tab tab = activity != null ? ((ChromeActivity) activity).getActivityTab() : null;
if (tab != null) {
- String message = (error);
- MessageInfoBar infobar = new MessageInfoBar(message);
- infobar.setExpireOnNavigation(false);
- tab.getInfoBarContainer().addInfoBar(infobar);
+ SimpleConfirmInfoBarBuilder.create(
+ tab, InfoBarIdentifier.CHROME_WINDOW_ERROR, error, false);
} else {
super.showCallbackNonExistentError(error);
}
« no previous file with comments | « chrome/android/BUILD.gn ('k') | chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698