Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 15963006: Implement WebPrescientNetworking::prefetchDNS. (Closed)

Created:
7 years, 7 months ago by kouhei (in TOK)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Implement WebPrescientNetworking::prefetchDNS. This is to obsolete prefetchDNS() API which lives in platform API. I would like to move it under WebPrescientNetworking. The corresponding Blink patch is http://crrev.com/15699002 BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204938

Patch Set 1 #

Patch Set 2 : prefetchHostName -> prefetchDNS #

Total comments: 2

Patch Set 3 : remove unused include #

Total comments: 2

Patch Set 4 : DISALLOW_COPY_AND_ASSIGN / rebase #

Patch Set 5 : add empty ctor #

Patch Set 6 : data() was deprecated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M chrome/renderer/net/prescient_networking_dispatcher.h View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/renderer/net/prescient_networking_dispatcher.cc View 1 2 3 4 5 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
kouhei (in TOK)
jam: Would you take a look? The corresponding Blink patch is http://crrev.com/15699002 Thanks!
7 years, 7 months ago (2013-05-27 07:44:02 UTC) #1
jam
On 2013/05/27 07:44:02, kouhei wrote: > jam: Would you take a look? > > The ...
7 years, 6 months ago (2013-05-28 16:07:03 UTC) #2
kouhei (in TOK)
thakis: Would you review this patch? The corresponding Blink patch is http://crrev.com/15699002 Thanks!
7 years, 6 months ago (2013-05-30 00:20:16 UTC) #3
Nico
Related patches should probably be mentioned in the CL description, not in a comment. I'm ...
7 years, 6 months ago (2013-05-30 00:44:56 UTC) #4
kouhei (in TOK)
Thank you for your comments! > Related patches should probably be mentioned in the CL ...
7 years, 6 months ago (2013-05-30 00:54:08 UTC) #5
Nico
jar@ should probably look at this. lgtm once this lgthim.
7 years, 6 months ago (2013-05-30 01:10:04 UTC) #6
jar (doing other things)
Note that the DNS pre-resolution code that you're using tends to throttle the rate at ...
7 years, 6 months ago (2013-05-30 21:55:03 UTC) #7
kouhei (in TOK)
Thanks for your comments! > Note that the DNS pre-resolution code that you're using tends ...
7 years, 6 months ago (2013-05-31 05:56:29 UTC) #8
jar (doing other things)
lgtm
7 years, 6 months ago (2013-05-31 17:23:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/15963006/14001
7 years, 6 months ago (2013-06-05 00:23:32 UTC) #10
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-06-05 00:56:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/15963006/33001
7 years, 6 months ago (2013-06-07 16:44:05 UTC) #12
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-06-07 17:06:21 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/15963006/58001
7 years, 6 months ago (2013-06-07 18:21:13 UTC) #14
commit-bot: I haz the power
7 years, 6 months ago (2013-06-07 21:39:13 UTC) #15
Message was sent while issue was closed.
Change committed as 204938

Powered by Google App Engine
This is Rietveld 408576698