Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 15962018: Fix ResourceLoadTiming Resolution Issue 4th step - remove unused macros from common.gypi (Closed)

Created:
7 years, 6 months ago by Pan
Modified:
7 years, 6 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix ResourceLoadTiming Resolution Issue 4th step - remove unused macros from common.gypi This is the 4th step to fix ResourceLoadTiming resolution issue, as chromium and blink part has been already smoothly switched to double resolution timestamps in ResourceLoadTiming, provisional macros can be removed now. Contributed by pan.deng@intel.com BUG=242452 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203373

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M build/common.gypi View 5 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Pan
Hi michaeln, could you please help review this? the macro is not used any more ...
7 years, 6 months ago (2013-05-29 09:11:02 UTC) #1
michaeln
lgtm
7 years, 6 months ago (2013-05-29 17:14:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pan.deng@intel.com/15962018/1
7 years, 6 months ago (2013-05-30 00:11:28 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-05-30 01:29:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pan.deng@intel.com/15962018/1
7 years, 6 months ago (2013-05-30 03:47:41 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=119906
7 years, 6 months ago (2013-05-30 06:31:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pan.deng@intel.com/15962018/1
7 years, 6 months ago (2013-05-30 10:25:25 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=119994
7 years, 6 months ago (2013-05-30 12:39:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pan.deng@intel.com/15962018/1
7 years, 6 months ago (2013-05-31 05:21:44 UTC) #9
commit-bot: I haz the power
7 years, 6 months ago (2013-05-31 09:08:40 UTC) #10
Message was sent while issue was closed.
Change committed as 203373

Powered by Google App Engine
This is Rietveld 408576698