codereview/views_chromium.py - Issue 15962014: Don't add issue owner as reviewer if owner clicked commit box.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: codereview/views_chromium.py

Issue 15962014: Don't add issue owner as reviewer if owner clicked commit box. (Closed)

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: codereview/views_chromium.py

===================================================================

--- a/codereview/views_chromium.py

+++ b/codereview/views_chromium.py

@@ -455,7 +455,8 @@

if 'commit' in request.POST:

request.issue.commit = form.cleaned_data['commit']

- if request.user.email() not in request.issue.reviewers:

+ if (request.user.email() not in request.issue.reviewers and

+ request.user.email() != request.issue.owner):

iannucci 2013/05/24 21:47:23 should also check request.issue.is_collaborator(re

request.issue.reviewers.append(db.Email(request.user.email()))

request.issue.put()

« no previous file with comments | « no previous file | no next file » | no next file with comments »