Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15962012: Revert "Identity API: Add component app for auth flow UI" (Closed)

Created:
7 years, 7 months ago by Michael Courage
Modified:
7 years, 7 months ago
CC:
chromium-reviews, Aaron Boodman, arv+watch_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert "Identity API: Add component app for auth flow UI" This reverts change 201736, which causes a working set size regression. BUG=243575 TBR=tonyg@chromium.org, miket@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202273

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -260 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/extensions/api/identity_private/identity_private_api.h View 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/browser/extensions/api/identity_private/identity_private_api.cc View 1 chunk +0 lines, -38 lines 0 comments Download
M chrome/browser/extensions/component_loader.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/resources/component_extension_resources.grd View 1 chunk +0 lines, -4 lines 0 comments Download
D chrome/browser/resources/identity_scope_approval_dialog/background.js View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/browser/resources/identity_scope_approval_dialog/manifest.json View 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/resources/identity_scope_approval_dialog/scope_approval_dialog.css View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/browser/resources/identity_scope_approval_dialog/scope_approval_dialog.html View 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/resources/identity_scope_approval_dialog/scope_approval_dialog.js View 1 chunk +0 lines, -46 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/common/extensions/api/api.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/api/identity_private.idl View 1 chunk +0 lines, -20 lines 0 comments Download
M chrome/common/extensions/extension_constants.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/extensions/extension_constants.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/permissions/api_permission.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/permissions/chrome_api_permissions.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
tonyg
lgtm For future reference, it is acceptable to TBR= reverts.
7 years, 7 months ago (2013-05-24 23:05:56 UTC) #1
Sonny
lgtm
7 years, 7 months ago (2013-05-24 23:06:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/courage@chromium.org/15962012/1
7 years, 7 months ago (2013-05-24 23:06:59 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=4973
7 years, 7 months ago (2013-05-24 23:18:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/courage@chromium.org/15962012/1
7 years, 7 months ago (2013-05-24 23:23:51 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, cacheinvalidation_unittests, cc_unittests, check_deps, chrome_frame_net_tests, ...
7 years, 7 months ago (2013-05-25 04:04:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/courage@chromium.org/15962012/1
7 years, 7 months ago (2013-05-25 07:10:24 UTC) #7
commit-bot: I haz the power
7 years, 7 months ago (2013-05-25 13:59:29 UTC) #8
Message was sent while issue was closed. 
Change committed as 202273

Powered by Google App Engine
This is Rietveld 408576698