Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 15962010: Indent media queries in CSS files for the DevTools. (Closed)

Created:
7 years, 7 months ago by umar.hansa
Modified:
7 years, 6 months ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Indent media queries in CSS files for the DevTools. Note, indented media queries had already existed in some places, so this CL also helps keep things more consistent. BUG=243813 R=vsevik Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151402

Patch Set 1 #

Patch Set 2 : Don't indent media queries but leave a comment explaining where the closing brace for media queries… #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -31 lines) Patch
M Source/devtools/front_end/auditsPanel.css View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/cm/cmdevtools.css View 1 1 chunk +6 lines, -6 lines 0 comments Download
M Source/devtools/front_end/dataGrid.css View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/elementsPanel.css View 1 2 chunks +2 lines, -2 lines 1 comment Download
M Source/devtools/front_end/inspector.css View 1 13 chunks +13 lines, -13 lines 0 comments Download
M Source/devtools/front_end/resourcesPanel.css View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sidebarPane.css View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timelinePanel.css View 1 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
umar.hansa
vsevik: Please can you review this CL, thank you.
7 years, 7 months ago (2013-05-24 18:48:25 UTC) #1
umar.hansa
7 years, 7 months ago (2013-05-24 18:49:55 UTC) #2
pfeldman
I can't say I like it much. I'd really like to see all selectors starting ...
7 years, 7 months ago (2013-05-27 12:17:29 UTC) #3
umar.hansa
No indentation for selectors within media queries is not something I've really seen before but ...
7 years, 7 months ago (2013-05-27 13:46:36 UTC) #4
pfeldman
yes please!
7 years, 7 months ago (2013-05-27 13:47:25 UTC) #5
umar.hansa
Patch #2 submitted.
7 years, 7 months ago (2013-05-27 14:03:02 UTC) #6
pfeldman
lgtm
7 years, 7 months ago (2013-05-27 14:04:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/umar.hansa@gmail.com/15962010/7001
7 years, 7 months ago (2013-05-27 14:04:34 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=6874
7 years, 7 months ago (2013-05-27 16:03:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/umar.hansa@gmail.com/15962010/7001
7 years, 6 months ago (2013-05-29 12:59:26 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=7414
7 years, 6 months ago (2013-05-29 15:23:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/umar.hansa@gmail.com/15962010/7001
7 years, 6 months ago (2013-05-29 15:32:07 UTC) #12
commit-bot: I haz the power
Change committed as 151402
7 years, 6 months ago (2013-05-29 16:59:30 UTC) #13
apavlov
https://chromiumcodereview.appspot.com/15962010/diff/7001/Source/devtools/front_end/elementsPanel.css File Source/devtools/front_end/elementsPanel.css (right): https://chromiumcodereview.appspot.com/15962010/diff/7001/Source/devtools/front_end/elementsPanel.css#newcode357 Source/devtools/front_end/elementsPanel.css:357: } /* media* / This line is wrong, which ...
7 years, 6 months ago (2013-05-30 11:18:01 UTC) #14
umar.hansa
7 years, 6 months ago (2013-05-30 13:11:47 UTC) #15
Message was sent while issue was closed.
Please accept my apologies, I should have verified my changes more carefully. I
saw https://codereview.chromium.org/15861024 has fixed this, thank you.

Powered by Google App Engine
This is Rietveld 408576698