Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7219)

Unified Diff: chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc

Issue 15961007: Highlight fields we know to be invalid but have no way of locally checking. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc
diff --git a/chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc b/chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc
index f92fbd4f626d1e534f79fab20e6fbe62eb86623f..f2a1d61ee693427f4dc2c46884dfdacb9eb4f5bc 100644
--- a/chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc
+++ b/chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc
@@ -349,7 +349,7 @@ jboolean AutofillDialogViewAndroid::EditingComplete(JNIEnv* env,
jint jsection) {
// Unfortunately, edits are not sent to the models, http://crbug.com/223919.
const DialogSection section = static_cast<DialogSection>(jsection);
- if (ValidateSection(section, AutofillDialogController::VALIDATE_FINAL)) {
+ if (ValidateSection(section, VALIDATE_FINAL)) {
UpdateOrFillSectionToJava(section, false, UNKNOWN_TYPE);
return true;
}
@@ -396,8 +396,7 @@ ScopedJavaLocalRef<jstring> AutofillDialogViewAndroid::ValidateField(
void AutofillDialogViewAndroid::ValidateSection(JNIEnv* env,
jobject obj,
jint section) {
- ValidateSection(static_cast<DialogSection>(section),
- AutofillDialogController::VALIDATE_EDIT);
+ ValidateSection(static_cast<DialogSection>(section), VALIDATE_EDIT);
}
void AutofillDialogViewAndroid::DialogSubmit(JNIEnv* env, jobject obj) {
@@ -458,8 +457,8 @@ bool AutofillDialogViewAndroid::RegisterAutofillDialogViewAndroid(JNIEnv* env) {
return RegisterNativesImpl(env);
}
-bool AutofillDialogViewAndroid::ValidateSection(
- DialogSection section, AutofillDialogController::ValidationType type) {
+bool AutofillDialogViewAndroid::ValidateSection(DialogSection section,
+ ValidationType type) {
DetailOutputMap detail_outputs;
GetUserInput(section, &detail_outputs);
ValidityData invalid_inputs =

Powered by Google App Engine
This is Rietveld 408576698