Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1069)

Issue 15960008: [Telemetry] Fix TestPageSetArchiveInfo.testModifications on windows. (Closed)

Created:
7 years, 7 months ago by tonyg
Modified:
7 years, 7 months ago
Reviewers:
dtu, nduca
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

[Telemetry] Fix TestPageSetArchiveInfo.testModifications on windows. We need to get the tempdir in a cross-platform manner. BUG=243535 TEST=python tools/telemetry/run_tests TestPageSetArchiveInfo.testModifications NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202228

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M tools/telemetry/telemetry/page/page_set_archive_info_unittest.py View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tonyg
7 years, 7 months ago (2013-05-24 23:15:10 UTC) #1
nduca
lgtm
7 years, 7 months ago (2013-05-24 23:38:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/15960008/1
7 years, 7 months ago (2013-05-24 23:39:49 UTC) #3
commit-bot: I haz the power
7 years, 7 months ago (2013-05-24 23:40:07 UTC) #4
Message was sent while issue was closed.
Change committed as 202228

Powered by Google App Engine
This is Rietveld 408576698