Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 15955005: Support XK_ugrave/XK_Ugrave key. (Closed)

Created:
7 years, 6 months ago by Seigo Nonaka
Modified:
7 years, 6 months ago
Reviewers:
Zachary Kuznia, sky
CC:
chromium-reviews, nona+watch_chromium.org, James Su, penghuang+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Support XK_ugrave/XK_Ugrave key. These keys are used in Canadian multilingual keyboard layout. BUG=245197 TEST=Manually done Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203859

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M ui/base/keycodes/keyboard_code_conversion_x.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Seigo Nonaka
Hi Zach, I'd like you to review this CL. Thank you.
7 years, 6 months ago (2013-05-31 07:39:48 UTC) #1
Zachary Kuznia
lgtm
7 years, 6 months ago (2013-06-02 13:15:58 UTC) #2
Seigo Nonaka
Zach, Thank you for your review! Adding sky@ as the owner of ui/ Hi Scott, ...
7 years, 6 months ago (2013-06-02 14:18:30 UTC) #3
Seigo Nonaka
Zach, Thank you for your review! Adding sky@ as the owner of ui/ Hi Scott, ...
7 years, 6 months ago (2013-06-02 14:18:43 UTC) #4
sky
LGTM
7 years, 6 months ago (2013-06-03 15:47:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/15955005/1
7 years, 6 months ago (2013-06-03 17:29:58 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-06-04 06:06:33 UTC) #7
Message was sent while issue was closed.
Change committed as 203859

Powered by Google App Engine
This is Rietveld 408576698