Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 15954008: Reset pending input method id. (Closed)

Created:
7 years, 7 months ago by Seigo Nonaka
Modified:
7 years, 6 months ago
Reviewers:
Zachary Kuznia
CC:
chromium-reviews, nkostylev+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Reset pending input method id. With this change, the responsibility of clearing |pending_input_method_| is moved to ChangeInputMethodInternal. BUG=243149 TEST=Manually checked on link device. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202607

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M chrome/browser/chromeos/input_method/input_method_manager_impl.cc View 3 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Seigo Nonaka
Hi Zach, I'd like you to review this CL. Thank you.
7 years, 6 months ago (2013-05-28 14:10:44 UTC) #1
Zachary Kuznia
lgtm
7 years, 6 months ago (2013-05-28 14:37:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/15954008/1
7 years, 6 months ago (2013-05-28 15:04:45 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-05-28 18:31:48 UTC) #4
Message was sent while issue was closed.
Change committed as 202607

Powered by Google App Engine
This is Rietveld 408576698