Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 15953004: Fixed button values for mac XBox gamepad userland driver. (Issue 243995) (Closed)

Created:
7 years, 7 months ago by josephg
Modified:
7 years, 6 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, sail+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fixed button values for mac XBox gamepad userland driver. Patch from Joseph Gentle <josephg@gmail.com>; R=jeremya@chromium.org BUG=243995 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202593

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/gamepad/gamepad_platform_data_fetcher_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
josephg
7 years, 7 months ago (2013-05-26 23:21:45 UTC) #1
jeremya
lgtm
7 years, 7 months ago (2013-05-26 23:32:07 UTC) #2
josephg
Mark - do you mind having a look?
7 years, 7 months ago (2013-05-28 01:18:15 UTC) #3
jeremya
+scottmg too, just in case :)
7 years, 7 months ago (2013-05-28 01:19:50 UTC) #4
scottmg
lgtm
7 years, 7 months ago (2013-05-28 01:50:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/josephg@gmail.com/15953004/1
7 years, 7 months ago (2013-05-28 01:50:56 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=118834
7 years, 7 months ago (2013-05-28 03:53:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/josephg@gmail.com/15953004/1
7 years, 7 months ago (2013-05-28 06:25:21 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=118893
7 years, 7 months ago (2013-05-28 08:21:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/josephg@gmail.com/15953004/1
7 years, 7 months ago (2013-05-28 08:38:23 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=118945
7 years, 7 months ago (2013-05-28 10:20:15 UTC) #11
Mark Mentovai
LGTM also.
7 years, 6 months ago (2013-05-28 12:33:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/josephg@gmail.com/15953004/1
7 years, 6 months ago (2013-05-28 16:04:17 UTC) #13
commit-bot: I haz the power
7 years, 6 months ago (2013-05-28 17:23:30 UTC) #14
Message was sent while issue was closed.
Change committed as 202593

Powered by Google App Engine
This is Rietveld 408576698