Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 15951008: Remove dependency of gsutil to download ndk (Closed)

Created:
7 years, 6 months ago by Yang Gu
Modified:
7 years, 6 months ago
Reviewers:
borenet, djsollen, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Remove dependency of gsutil to download ndk Currently we use gsutil to download ndk. However, it requires extra steps to install, and is not convenient to configure (several steps to enable Google storage), especially for developers behind proxy (need to set config of boto). Chromium provides some python scripts to help download nacl toolchains that can meet this need well. So this patch basically borrows two python scripts from there, and makes some according changes to remove the usage of gsutil. With new script, we may also implement some advanced features, such as hash check, so that the download would be more intelligent. BUG= Committed: http://code.google.com/p/skia/source/detail?r=9311

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+442 lines, -7 lines) Patch
M platform_tools/android/bin/android_setup.sh View 2 chunks +8 lines, -7 lines 0 comments Download
A platform_tools/android/bin/download_toolchains.py View 1 chunk +19 lines, -0 lines 0 comments Download
A platform_tools/android/bin/download_utils.py View 1 chunk +323 lines, -0 lines 0 comments Download
A platform_tools/android/bin/http_download.py View 1 chunk +92 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang Gu
7 years, 6 months ago (2013-05-29 09:12:08 UTC) #1
djsollen
Thanks! lgtm
7 years, 6 months ago (2013-05-29 13:05:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/yang.gu@intel.com/15951008/1
7 years, 6 months ago (2013-05-29 13:06:12 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-05-29 13:26:34 UTC) #4
Message was sent while issue was closed.
Change committed as 9311

Powered by Google App Engine
This is Rietveld 408576698