QUIC - Added StringToHexASCIIDump to return a hex+ASCII dump in the

net/quic/quic_utils_test.cc

Index: net/quic/quic_utils_test.cc
diff --git a/net/quic/quic_utils_test.cc b/net/quic/quic_utils_test.cc
index a59c1e7fcb00eb171497f9899a819294a1df9716..0e50aec0ec1dd36e247cd7f87d1e97afd27db8b7 100644
--- a/net/quic/quic_utils_test.cc
+++ b/net/quic/quic_utils_test.cc
@@ -6,10 +6,28 @@
 
 #include "testing/gtest/include/gtest/gtest.h"
 
+using base::StringPiece;
+using std::string;
+
 namespace net {
 namespace test {
 namespace {
 
+// A test string and a hex+ASCII dump of the same string.
+const unsigned char kString[] = {
+  0x00, 0x90, 0x69, 0xbd, 0x54, 0x00, 0x00, 0x0d,
+  0x61, 0x0f, 0x01, 0x89, 0x08, 0x00, 0x45, 0x00,
+  0x00, 0x1c, 0xfb, 0x98, 0x40, 0x00, 0x40, 0x01,
+  0x7e, 0x18, 0xd8, 0xef, 0x23, 0x01, 0x45, 0x5d,
+  0x7f, 0xe2, 0x08, 0x00, 0x6b, 0xcb, 0x0b, 0xc6,
+  0x80, 0x6e
+};
+
+const unsigned char kHexDump[] =
+"0x0000:  0090 69bd 5400 000d 610f 0189 0800 4500  ..i.T...a.....E.\n"
+"0x0010:  001c fb98 4000 4001 7e18 d8ef 2301 455d  ....@.@.~...#.E]\n"
+"0x0020:  7fe2 0800 6bcb 0bc6 806e                 ....k....n\n";
+
 TEST(QuicUtilsTest, StreamErrorToString) {
   EXPECT_STREQ("QUIC_BAD_APPLICATION_PAYLOAD",
                QuicUtils::StreamErrorToString(QUIC_BAD_APPLICATION_PAYLOAD));
@@ -20,6 +38,36 @@ TEST(QuicUtilsTest, ErrorToString) {
                QuicUtils::ErrorToString(QUIC_NO_ERROR));
 }
 
+TEST(QuicUtilsTest, StringToHexASCIIDumpArgTypes) {
+  // Verify that char*, string and StringPiece are all valid argument types.
+  struct {
+    const string input;
+    const string expected;
+  } tests[] = {
+    { "", "", },
+    { "A",   "0x0000:  41                                       A\n", },
+    { "AB",  "0x0000:  4142                                     AB\n", },
+    { "ABC", "0x0000:  4142 43                                  ABC\n", },
+    { "original",
+      "0x0000:  6f72 6967 696e 616c                      original\n", },
+  };
+
+  for (size_t i = 0; i < ARRAYSIZE_UNSAFE(tests); ++i) {
+    EXPECT_EQ(tests[i].expected,
+              QuicUtils::StringToHexASCIIDump(tests[i].input.c_str()));
+    EXPECT_EQ(tests[i].expected,
+              QuicUtils::StringToHexASCIIDump(tests[i].input));
+    EXPECT_EQ(tests[i].expected,
+              QuicUtils::StringToHexASCIIDump(StringPiece(tests[i].input)));
+  }
+}
+
+TEST(QuicUtilsTest, StringToHexASCIIDumpSuccess) {
+  EXPECT_EQ(string(reinterpret_cast<const char*>(kHexDump)),
+      QuicUtils::StringToHexASCIIDump(
+          string(reinterpret_cast<const char*>(kString), sizeof(kString))));
+}
+
 }  // namespace
 }  // namespace test
 }  // namespace net