Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15950011: content: Move kViewSourceScheme constant into content namespace. (Closed)

Created:
7 years, 6 months ago by tfarina
Modified:
7 years, 6 months ago
CC:
chromium-reviews, Avi (use Gerrit), jam, creis+watch_chromium.org, grt+watch_chromium.org, amit, browser-components-watch_chromium.org, cbentzel+watch_chromium.org, sail+watch_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, robertshield, ajwong+watch_chromium.org, chromium-apps-reviews_chromium.org, markusheintz_, James Su
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -68 lines) Patch
M chrome/browser/autocomplete/autocomplete_input.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_helper_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/history/history_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/url_fixer_upper.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/view_source_browsertest.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_navigator.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_navigator_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/applescript/tab_applescript.mm View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/singleton_tabs.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/user_script_slave.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/chrome_active_document.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/chrome_frame_activex_base.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/navigation_constraints.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/ui_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_url_handler_impl.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/child_process_security_policy_impl.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/browser/child_process_security_policy_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_manager_browsertest.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M content/browser/web_contents/navigation_entry_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/web_contents_delegate.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M content/public/common/url_constants.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/common/url_constants.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/net/url_request_mock_http_job.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/net_util.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
tfarina
Boring review, nothing excited, sorry :( Lei chrome/ Eric net/ Joi content/ Greg chrome_frame/
7 years, 6 months ago (2013-05-30 00:21:12 UTC) #1
Lei Zhang
chrome/ lgtm
7 years, 6 months ago (2013-05-30 00:40:12 UTC) #2
eroman
net/ lgtm
7 years, 6 months ago (2013-05-30 00:44:27 UTC) #3
Jói
LGTM for //content.
7 years, 6 months ago (2013-05-30 12:16:37 UTC) #4
grt (UTC plus 2)
chrome_frame/ lgtm
7 years, 6 months ago (2013-05-30 14:30:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/15950011/1
7 years, 6 months ago (2013-05-30 20:36:25 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=5967
7 years, 6 months ago (2013-05-30 20:45:32 UTC) #7
Lei Zhang
+piman, aka an actual content/ OWNER
7 years, 6 months ago (2013-05-30 20:49:17 UTC) #8
piman
lgtm
7 years, 6 months ago (2013-05-30 20:53:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/15950011/1
7 years, 6 months ago (2013-05-30 20:58:13 UTC) #10
commit-bot: I haz the power
7 years, 6 months ago (2013-05-30 22:13:52 UTC) #11
Message was sent while issue was closed. 
Change committed as 203241

Powered by Google App Engine
This is Rietveld 408576698