chrome/browser/ui/webui/constrained_web_dialog_ui_browsertest.cc - Issue 15949029: Use a direct include of utf_string_conversions.h in chrome/browser/ui/, part 2.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/webui/constrained_web_dialog_ui_browsertest.cc

Issue 15949029: Use a direct include of utf_string_conversions.h in chrome/browser/ui/, part 2. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/ui/webui/conflicts_ui.cc ('k') | chrome/browser/ui/webui/crashes_ui.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/test/ui/ui_test.h"	5 #include "chrome/test/ui/ui_test.h"

6	6

7 #include "base/utf_string_conversions.h"	7 #include "base/strings/utf_string_conversions.h"

8 #include "chrome/browser/profiles/profile.h"	8 #include "chrome/browser/profiles/profile.h"

9 #include "chrome/browser/ui/browser.h"	9 #include "chrome/browser/ui/browser.h"

10 #include "chrome/browser/ui/tabs/tab_strip_model.h"	10 #include "chrome/browser/ui/tabs/tab_strip_model.h"

11 #include "chrome/browser/ui/webui/constrained_web_dialog_ui.h"	11 #include "chrome/browser/ui/webui/constrained_web_dialog_ui.h"

12 #include "chrome/common/url_constants.h"	12 #include "chrome/common/url_constants.h"

13 #include "chrome/test/base/in_process_browser_test.h"	13 #include "chrome/test/base/in_process_browser_test.h"

14 #include "chrome/test/base/ui_test_utils.h"	14 #include "chrome/test/base/ui_test_utils.h"

15 #include "components/web_modal/web_contents_modal_dialog_manager.h"	15 #include "components/web_modal/web_contents_modal_dialog_manager.h"

16 #include "content/public/browser/web_contents.h"	16 #include "content/public/browser/web_contents.h"

17 #include "content/public/browser/web_contents_observer.h"	17 #include "content/public/browser/web_contents_observer.h"

(...skipping 79 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
97	97

98 ConstrainedWebDialogBrowserTestObserver observer(new_tab.get());	98 ConstrainedWebDialogBrowserTestObserver observer(new_tab.get());

99 dialog_delegate->ReleaseWebContentsOnDialogClose();	99 dialog_delegate->ReleaseWebContentsOnDialogClose();

100 dialog_delegate->OnDialogCloseFromWebUI();	100 dialog_delegate->OnDialogCloseFromWebUI();

101	101

102 ASSERT_FALSE(observer.contents_destroyed());	102 ASSERT_FALSE(observer.contents_destroyed());

103 EXPECT_FALSE(IsShowingWebContentsModalDialog(web_contents));	103 EXPECT_FALSE(IsShowingWebContentsModalDialog(web_contents));

104 new_tab.reset();	104 new_tab.reset();

105 EXPECT_TRUE(observer.contents_destroyed());	105 EXPECT_TRUE(observer.contents_destroyed());

106 }	106 }

OLD	NEW