Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 15949025: In components/autofill, move renderer/ to content/renderer (Closed)

Created:
7 years, 6 months ago by blundell
Modified:
7 years, 6 months ago
Reviewers:
tfarina, Nico, Jói
CC:
chromium-reviews, Raman Kakilate, benquan, jam, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman, rouslan+autofillwatch_chromium.org, Ben Murdoch, selim
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

In components/autofill, move renderer/ to content/renderer This change is part of moving components/autofill into its eventual structure as a layered component. This CL additionally adds a README in components/autofill that explains the project of making autofill into a layered component. TBR=thakis BUG=247015 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204642

Patch Set 1 #

Total comments: 2

Patch Set 2 : Response to reviews #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -4335 lines) Patch
M chrome/chrome_renderer.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/autofill/form_autofill_browsertest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/renderer/autofill/page_click_tracker_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/renderer/autofill/password_autofill_agent_browsertest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/renderer/autofill/password_generation_manager_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/test/base/chrome_render_view_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/chrome_render_view_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/autofill.gypi View 2 chunks +14 lines, -14 lines 0 comments Download
A components/autofill/README View 1 1 chunk +21 lines, -0 lines 0 comments Download
A + components/autofill/content/renderer/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/autofill/content/renderer/autofill_agent.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + components/autofill/content/renderer/autofill_agent.cc View 3 chunks +6 lines, -6 lines 0 comments Download
A + components/autofill/content/renderer/form_autofill_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/autofill/content/renderer/form_autofill_util.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + components/autofill/content/renderer/form_cache.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/autofill/content/renderer/form_cache.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/autofill/content/renderer/page_click_listener.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/autofill/content/renderer/page_click_tracker.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/autofill/content/renderer/page_click_tracker.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + components/autofill/content/renderer/password_autofill_agent.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/autofill/content/renderer/password_autofill_agent.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + components/autofill/content/renderer/password_generation_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/autofill/content/renderer/password_generation_manager.cc View 2 chunks +4 lines, -4 lines 0 comments Download
D components/autofill/renderer/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D components/autofill/renderer/autofill_agent.h View 1 chunk +0 lines, -295 lines 0 comments Download
D components/autofill/renderer/autofill_agent.cc View 1 chunk +0 lines, -984 lines 0 comments Download
D components/autofill/renderer/form_autofill_util.h View 1 chunk +0 lines, -139 lines 0 comments Download
D components/autofill/renderer/form_autofill_util.cc View 1 chunk +0 lines, -1030 lines 0 comments Download
D components/autofill/renderer/form_cache.h View 1 chunk +0 lines, -77 lines 0 comments Download
D components/autofill/renderer/form_cache.cc View 1 chunk +0 lines, -297 lines 0 comments Download
D components/autofill/renderer/page_click_listener.h View 1 chunk +0 lines, -36 lines 0 comments Download
D components/autofill/renderer/page_click_tracker.h View 1 chunk +0 lines, -71 lines 0 comments Download
D components/autofill/renderer/page_click_tracker.cc View 1 chunk +0 lines, -146 lines 0 comments Download
D components/autofill/renderer/password_autofill_agent.h View 1 chunk +0 lines, -139 lines 0 comments Download
D components/autofill/renderer/password_autofill_agent.cc View 1 chunk +0 lines, -686 lines 0 comments Download
D components/autofill/renderer/password_generation_manager.h View 1 chunk +0 lines, -90 lines 0 comments Download
D components/autofill/renderer/password_generation_manager.cc View 1 chunk +0 lines, -257 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
blundell
Submitting this first one for actual review for two reasons: 1) A quick look over ...
7 years, 6 months ago (2013-06-05 16:58:04 UTC) #1
tfarina
On Wed, Jun 5, 2013 at 1:58 PM, <blundell@chromium.org> wrote: > Reviewers: Jói, > > ...
7 years, 6 months ago (2013-06-05 18:08:45 UTC) #2
Jói
LGTM, modulo one nit from me, and a fix to Thiago's comment. https://codereview.chromium.org/15949025/diff/1/components/autofill/README.txt File components/autofill/README.txt ...
7 years, 6 months ago (2013-06-05 19:08:54 UTC) #3
blundell
TBR'ing thakis for the changes made under chrome/ by mass-rename.sh. https://codereview.chromium.org/15949025/diff/1/components/autofill/README.txt File components/autofill/README.txt (right): https://codereview.chromium.org/15949025/diff/1/components/autofill/README.txt#newcode2 ...
7 years, 6 months ago (2013-06-06 07:23:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/15949025/6001
7 years, 6 months ago (2013-06-06 07:24:28 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-06 23:03:50 UTC) #6
Message was sent while issue was closed.
Change committed as 204642

Powered by Google App Engine
This is Rietveld 408576698