Issue 15947003: Remove the message box dialog black border.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15947003: Remove the message box dialog black border. (Closed)

Created:
7 years, 7 months ago by msw

Modified:
7 years, 7 months ago

Reviewers:
msw, sky

CC:
chromium-reviews, tfarina

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

Remove the message box dialog black border. SimpleMessageBoxViews uses Widget::CreateWindow. Use DialogDelegate::CreateDialogWidget instead. See before/after pics at http://crbug.com/166075#c97 Trigger by one of the following methods (there are many): 1) Open all tabs on a big bookmark folder. 2) encounter extension/profile/print/etc. errors. See many uses of chrome::ShowMessageBox at: https://code.google.com/p/chromium/codesearch#search/&sq=package:chromium&q=chrome::ShowMessageBox BUG=166075, 242284 TEST=Message box dialog does not have a black border. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202057

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -5 lines)			Patch
	M	chrome/browser/ui/views/simple_message_box_views.cc	View		1 chunk	+1 line, -5 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/15947003/1

7 years, 7 months ago (2013-05-23 23:50:11 UTC) #3

Message was sent while issue was closed.

Change committed as 202057