Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 15945002: Switch "win split" to chromium_builder_tests. (Closed)

Created:
7 years, 7 months ago by scottmg
Modified:
7 years, 7 months ago
Reviewers:
iannucci, scottmg
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Switch "win split" to chromium_builder_tests. Too slow as VM builder otherwise. R=iannucci@chromium.org BUG=241097 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=201927

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M masters/master.chromium/master_full_cfg.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
scottmg
7 years, 7 months ago (2013-05-23 23:19:47 UTC) #1
iannucci
lgtm https://codereview.chromium.org/15945002/diff/1/masters/master.chromium/master_full_cfg.py File masters/master.chromium/master_full_cfg.py (right): https://codereview.chromium.org/15945002/diff/1/masters/master.chromium/master_full_cfg.py#newcode65 masters/master.chromium/master_full_cfg.py:65: options=['--build-tool=ninja', 'chromium_builder_tests'], add a '--' in between these ...
7 years, 7 months ago (2013-05-23 23:21:19 UTC) #2
scottmg
On 2013/05/23 23:21:19, iannucci wrote: > lgtm > > https://codereview.chromium.org/15945002/diff/1/masters/master.chromium/master_full_cfg.py > File masters/master.chromium/master_full_cfg.py (right): > ...
7 years, 7 months ago (2013-05-23 23:22:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/15945002/3
7 years, 7 months ago (2013-05-23 23:25:06 UTC) #4
commit-bot: I haz the power
7 years, 7 months ago (2013-05-23 23:25:53 UTC) #5
Message was sent while issue was closed.
Change committed as 201927

Powered by Google App Engine
This is Rietveld 408576698