Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 15942017: [Android] Fix component build again. (Closed)

Created:
7 years, 6 months ago by Yaron
Modified:
7 years, 6 months ago
CC:
chromium-reviews, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, android-webview-reviews_chromium.org, cjhopman, scherkus (not reviewing), Isaac (away), bulach
Visibility:
Public.

Description

[Android] Fix component build again. After this, android_clang_dbg (tree-closer) will be switched to use components. BUG=247855 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205926

Patch Set 1 #

Patch Set 2 : rebase + memorypressurelistener #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M android_webview/native/webview_native.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M base/android/memory_pressure_listener_android.h View 1 1 chunk +1 line, -1 line 0 comments Download
M base/base.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/content_tests.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/browser/android/synchronous_compositor.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M gpu/gpu.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Yaron
joth: aw jam: content gpu: gman base: mark
7 years, 6 months ago (2013-06-11 01:02:47 UTC) #1
joth
On 2013/06/11 01:02:47, Yaron wrote: > joth: aw lgtm stamp > jam: content > gpu: ...
7 years, 6 months ago (2013-06-11 01:03:57 UTC) #2
greggman
lgtm
7 years, 6 months ago (2013-06-11 01:07:37 UTC) #3
jam
lgtm
7 years, 6 months ago (2013-06-11 20:42:02 UTC) #4
Yaron
mark: ping
7 years, 6 months ago (2013-06-12 16:20:36 UTC) #5
Mark Mentovai
LGTM
7 years, 6 months ago (2013-06-12 16:25:21 UTC) #6
Yaron
Thanks. Rebased and snuck in an export to MemoryPressureListenerAndroid that was added in https://codereview.chromium.org/15995014/ and ...
7 years, 6 months ago (2013-06-12 16:48:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/15942017/12001
7 years, 6 months ago (2013-06-12 16:49:02 UTC) #8
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=49151
7 years, 6 months ago (2013-06-12 18:32:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/15942017/12001
7 years, 6 months ago (2013-06-12 18:36:11 UTC) #10
commit-bot: I haz the power
Change committed as 205926
7 years, 6 months ago (2013-06-12 20:54:30 UTC) #11
bulach
7 years, 6 months ago (2013-06-13 10:18:25 UTC) #12
Message was sent while issue was closed.
lgtm, sorry and thanks! :)

Powered by Google App Engine
This is Rietveld 408576698