Stop offering Autocheckout bubble on the forms of no interest.

components/autofill/browser/autofill_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/browser/autofill_manager.h"
 
 #include <stddef.h>
 
 #include <limits>
 #include <map>
@@ skipping 152 matching lines @@
       it->GetMatchingTypes(value, app_locale, &matching_types);
     }
 
     if (matching_types.empty())
       matching_types.insert(UNKNOWN_TYPE);
 
     field->set_possible_types(matching_types);
   }
 }
 
+// Returns true if server returned known field types to one or more fields in
+// this form.
+bool HasServerSpecifiedFieldTypes(const FormStructure& form_structure) {
+  for (size_t i = 0; i < form_structure.field_count(); ++i) {
+    if (form_structure.field(i)->server_type() != NO_SERVER_DATA)
+      return true;
+  }
+  return false;
+}
+
 }  // namespace
 
 // static
 void AutofillManager::CreateForWebContentsAndDelegate(
     content::WebContents* contents,
     autofill::AutofillManagerDelegate* delegate,
     const std::string& app_locale,
     AutofillDownloadManagerState enable_download_manager) {
   if (FromWebContents(contents))
     return;
@@ skipping 657 matching lines @@
 
 void AutofillManager::OnDidEndTextFieldEditing() {
   if (external_delegate_)
     external_delegate_->DidEndTextFieldEditing();
 }
 
 void AutofillManager::OnClickFailed(autofill::AutocheckoutStatus status) {
   autocheckout_manager_.OnClickFailed(status);
 }
 
-void AutofillManager::OnMaybeShowAutocheckoutBubble(
-    const GURL& source_url,
-    const content::SSLStatus& ssl_status,
-    const gfx::RectF& bounding_box) {
-  if (!IsAutofillEnabled())
-    return;
-
-  autocheckout_manager_.MaybeShowAutocheckoutBubble(
-      source_url,
-      ssl_status,
-      bounding_box);
-}
-
 std::string AutofillManager::GetAutocheckoutURLPrefix() const {
   if (!web_contents())
     return std::string();
 
   autofill::autocheckout::WhitelistManager* whitelist_manager =
       manager_delegate_->GetAutocheckoutWhitelistManager();
 
   return whitelist_manager->GetMatchedURLPrefix(web_contents()->GetURL());
 }
 
@@ skipping 45 matching lines @@
     const TimeTicks& submission_time) {
   submitted_form->LogQualityMetrics(*metric_logger_,
                                     load_time,
                                     interaction_time,
                                     submission_time);
 
   if (submitted_form->ShouldBeCrowdsourced())
     UploadFormData(*submitted_form);
 }
 
+void AutofillManager::OnMaybeShowAutocheckoutBubble(
+    const FormData& form,
+    const gfx::RectF& bounding_box) {
+  if (!IsAutofillEnabled())
+    return;
+
+  // Don't show bubble if corresponding FormStructure doesn't have anything to
+  // autofill.
+  FormStructure* cached_form;
+  if (!FindCachedForm(form, &cached_form))
+    return;
+
+  // Don't offer Autocheckout bubble if Autofill server is not aware of this
+  // form in the context of Autocheckout experiment.
+  if (!HasServerSpecifiedFieldTypes(*cached_form))
+    return;
+
+  autocheckout_manager_.MaybeShowAutocheckoutBubble(
+      form.origin,
+      form.ssl_status,
+      bounding_box);
+}
+
 void AutofillManager::UploadFormData(const FormStructure& submitted_form) {
   if (!download_manager_)
     return;
 
   // Check if the form is among the forms that were recently auto-filled.
   bool was_autofilled = false;
   std::string form_signature = submitted_form.FormSignature();
   for (std::list<std::string>::const_iterator it =
            autofilled_form_signatures_.begin();
        it != autofilled_form_signatures_.end() && !was_autofilled;
@@ skipping 358 matching lines @@
 
 void AutofillManager::UpdateInitialInteractionTimestamp(
     const TimeTicks& interaction_timestamp) {
   if (initial_interaction_timestamp_.is_null() ||
       interaction_timestamp < initial_interaction_timestamp_) {
     initial_interaction_timestamp_ = interaction_timestamp;
   }
 }
 
 }  // namespace autofill