Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: webkit/glue/cpp_bound_class.h

Issue 15941006: Track NPObject ownership by the originating plugins' NPP identifier. [2/3] (Chrome) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix CppBoundClass. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/webplugin_delegate_proxy.cc ('k') | webkit/glue/cpp_bound_class.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/cpp_bound_class.h
diff --git a/webkit/glue/cpp_bound_class.h b/webkit/glue/cpp_bound_class.h
index 3d7427d8279c0f394275399103e6115102696b83..cdc80a608e532302bbbb4812114a587fc89479f5 100644
--- a/webkit/glue/cpp_bound_class.h
+++ b/webkit/glue/cpp_bound_class.h
@@ -133,10 +133,12 @@ class WEBKIT_GLUE_EXPORT CppBoundClass {
// reference to this object, and it is released on deletion.
CppVariant self_variant_;
- // True if our np_object has been bound to a WebFrame, in which case it must
- // be unregistered with V8 when we delete it.
+ // TODO(wez): Remove once crrev.com/14019005 lands.
bool bound_to_frame_;
+ // Dummy NPP to use to register as owner for NPObjects.
+ scoped_ptr<NPP_t> npp_;
+
DISALLOW_COPY_AND_ASSIGN(CppBoundClass);
};
« no previous file with comments | « content/renderer/webplugin_delegate_proxy.cc ('k') | webkit/glue/cpp_bound_class.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698