Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 15941006: Track NPObject ownership by the originating plugins' NPP identifier. [2/3] (Chrome) (Closed)

Created:
7 years, 7 months ago by Wez
Modified:
7 years, 7 months ago
Reviewers:
Bernhard Bauer, jamesr
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Track NPObject ownership by the originating plugins' NPP identifier. [2/3] (Chrome) This CL updates Chrome to return plugin NPP identifiers for NPAPI, PPAPI and browser plugins, and to make the necessary calls into Blink to support object ownership tracking. This CL is a re-land of crrev.com/15007012, which was somehow landed by CQ despite breaking ClickToPlayPluginTest.NoCallbackAtLoad. It requires Blink CL crrev.com/14989014, and is itself required by Blink CL crrev.com/14019005. BUG=152006 TBR=jamesr,bauerb Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202408

Patch Set 1 #

Patch Set 2 : Fix CppBoundClass. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -24 lines) Patch
M chrome/renderer/plugins/webview_plugin.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/renderer/plugins/webview_plugin.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.cc View 3 chunks +14 lines, -0 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin_bindings.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/webplugin_delegate_proxy.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/webplugin_delegate_proxy.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M webkit/glue/cpp_bound_class.h View 1 1 chunk +4 lines, -2 lines 0 comments Download
M webkit/glue/cpp_bound_class.cc View 1 3 chunks +12 lines, -9 lines 0 comments Download
M webkit/plugins/npapi/webplugin_delegate.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/plugins/npapi/webplugin_delegate_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/plugins/npapi/webplugin_delegate_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/plugins/npapi/webplugin_impl.h View 2 chunks +4 lines, -0 lines 0 comments Download
M webkit/plugins/npapi/webplugin_impl.cc View 5 chunks +32 lines, -7 lines 0 comments Download
M webkit/plugins/ppapi/message_channel.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/plugin_object.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.h View 3 chunks +9 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.cc View 3 chunks +8 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_webplugin_impl.h View 2 chunks +3 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_webplugin_impl.cc View 3 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Wez
FYI; crrev.com/15007012 somehow landed despite breaking ClickToPlayPluginTest.NoCallbackAtLoad. This CL is a re-land with the necessary ...
7 years, 7 months ago (2013-05-27 07:44:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/15941006/2001
7 years, 7 months ago (2013-05-27 07:44:27 UTC) #2
commit-bot: I haz the power
7 years, 7 months ago (2013-05-27 13:14:04 UTC) #3
Message was sent while issue was closed.
Change committed as 202408

Powered by Google App Engine
This is Rietveld 408576698